BCDA-9385: Update bulk request response when attribution file not found (#1201)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9385

## 🛠 Changes

- updated response when attribution file is not found from HTTP 500 ->
404.
- updated tests

## ℹ️ Context

HTTP 500s should be reserved for serious, unexpected errors. This was a
result of requesting expired runout data, which caused alerting to
trigger; this is an expected outcome around this time of the PY and
should be handled more gracefully.

An additional ticket has been created to give a more informative/helpful
response to our entities when runout data has been requested past its
expiry date: https://jira.cms.gov/browse/BCDA-9386


<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Tests updated and passing.

Author: laurenkrugen-navapbc

bcda/api/requests.go

@@ -526,8 +526,14 @@ func (h *Handler) bulkRequest(w http.ResponseWriter, r *http.Request, reqType co
 		fileType,
 	)
 	if err != nil {
-		logger.Error("error finding latest cclf file: %+v", err)
-		h.RespWriter.Exception(r.Context(), w, http.StatusInternalServerError, responseutils.DbErr, "")
+		// TODO: this can occur when runout data is expired, we should update error handling: BCDA-9386
+		if errors.As(err, &service.CCLFNotFoundError{}) {
+			logger.Warningf("cclf file not found: %+v", err)
+			h.RespWriter.Exception(r.Context(), w, http.StatusNotFound, responseutils.NotFoundErr, "failed to start job; attribution file not found.")
+			return
+		}
+		logger.Errorf("failed to retrieve latest cclf file: %+v", err)
+		h.RespWriter.Exception(r.Context(), w, http.StatusInternalServerError, responseutils.DbErr, responseutils.DbErr)
 		return
 	}
 

bcda/api/requests_test.go

@@ -130,8 +130,8 @@ func (s *RequestsTestSuite) TestRunoutEnabled() {
 	}{
 		{"Successful", nil, http.StatusAccepted, apiVersionOne, true},
 		{"Successful v2", nil, http.StatusAccepted, apiVersionTwo, true},
-		{"FindCCLFFiles error", CCLFNotFoundOperationOutcomeError{}, http.StatusInternalServerError, apiVersionOne, false},
-		{"FindCCLFFiles error v2", CCLFNotFoundOperationOutcomeError{}, http.StatusInternalServerError, apiVersionTwo, false},
+		{"FindCCLFFiles error", CCLFNotFoundOperationOutcomeError{}, http.StatusNotFound, apiVersionOne, false},
+		{"FindCCLFFiles error v2", DatabaseError{}, http.StatusInternalServerError, apiVersionTwo, false},
 		{constants.DefaultError, QueueError{}, http.StatusInternalServerError, apiVersionOne, true},
 		{constants.DefaultError + " v2", QueueError{}, http.StatusInternalServerError, apiVersionTwo, true},
 	}
@@ -155,7 +155,9 @@ func (s *RequestsTestSuite) TestRunoutEnabled() {
 				mockSvc.On("GetLatestCCLFFile", testUtils.CtxMatcher, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(&models.CCLFFile{PerformanceYear: 24}, nil)
 				enqueuer.On("AddPrepareJob", mock.Anything, mock.Anything).Return(nil)
 			case CCLFNotFoundOperationOutcomeError{}:
-				mockSvc.On("GetLatestCCLFFile", testUtils.CtxMatcher, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("db error"))
+				mockSvc.On("GetLatestCCLFFile", testUtils.CtxMatcher, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, service.CCLFNotFoundError{})
+			case DatabaseError{}:
+				mockSvc.On("GetLatestCCLFFile", testUtils.CtxMatcher, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil, errors.New("database error"))
 			case QueueError{}:
 				mockSvc.On("GetLatestCCLFFile", testUtils.CtxMatcher, mock.AnythingOfType("string"), mock.AnythingOfType("time.Time"), mock.AnythingOfType("time.Time"), mock.Anything).
 					Return(&models.CCLFFile{PerformanceYear: 24}, nil)
@@ -1229,3 +1231,9 @@ type QueueError struct{}
 func (e QueueError) Error() string {
 	return "error"
 }
+
+type DatabaseError struct{}
+
+func (e DatabaseError) Error() string {
+	return "error"
+}