BCDA-9225: Reconfigure golang linting (#1155)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9225

## 🛠 Changes

- configured the standard golangci-lint pre-commit hook to replace the
wrapper hook we had been using before
- set predefined versions for our linters that we can update ourselves
(this version management may change when we upgrade to go 1.24)
- updated configuration of ci linter to specifically lint the changes
that are different from main
- configured setup-go job to fetch the go version from go.mod in all
workflows
- changed create-group integration test to hard delete created group
instead of soft delete

<!-- What was added, updated, or removed in this PR? -->

## ℹ️ Context

There are two golang-ci linters configured for this repo: one in a
pre-commit hook, and one in a docker container which is run by a make
command during ci-checks.

The goals for my changes here were the following:
- reduce the number of false positives with pre-commit linting errors.
this was addressed by changing the pre-commit linting scope from "every
package of every updated file" to "every updated line" -- there was
clearly something buggy about the former, but I'm not quite sure what it
was.
- bring the pre-commit and the ci-checks linters closer together with
respect to their versions and the results they create
- ensure that the pre-commit linter does not take too long
- define a set version for the linters that we can increment manually,
so as to increase the stability of our ci workflow
- only lint new changes for a specific commit during the pre-commit hook
- lint all changes to main for the PR linter

Also for the create-group integration test, it turns out soft deleting
the group is not enough to make the test re-runnable

## 🧪 Validation

for the linters:
1. create a new branch from this branch
2. make an update to any go file with a linting error. when you try to
commit, the pre-commit hook should catch the error and not raise a bunch
of false positives
3. commit the error from step 2 with `go commit --no-verify` and push
the branch. verify that the `ci-checks` workflow catches the error

for the create-group workflow:
1. run the workflow and verify that it passes
2. immediately re-run the workflow and verify that it passes again 

<!-- How were the changes verified? Did you fully test the acceptance
criteria in the ticket? Provide reproducible testing instructions and
screenshots if applicable. -->

Author: michaeljvaldes

.github/workflows/admin-aco-deny-deploy.yml

@@ -34,7 +34,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build admin-aco-deny zip file
         env:
           CGO_ENABLED: 0

.github/workflows/admin-create-aco-creds-deploy.yml

@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build admin-create-aco-creds zip file
         env:
           CGO_ENABLED: 0

.github/workflows/admin-create-aco-deploy.yml

@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build admin_create_aco zip file
         env:
           CGO_ENABLED: 0

.github/workflows/admin-create-group-deploy.yml

@@ -35,7 +35,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build create-group zip file
         env:
           CGO_ENABLED: 0

.github/workflows/admin-create-group-integration-test.yml

@@ -79,15 +79,15 @@ jobs:
         run: |
           HOST=$(aws rds describe-db-instances --db-instance-identifier bcda-dev 2>&1 | jq -r '.DBInstances[0].Endpoint.Address' 2>&1)
           CONNECTION_URL=$(echo $CONNECTION_INFO 2>&1 | sed -E "s/@.*\/bcda/\@$HOST\/bcda/" 2>&1)
-          GROUP_COUNT=`psql -tA "$CONNECTION_URL" -c "SELECT COUNT(*) FROM groups WHERE group_id='${{ env.GROUP }}' AND deleted_at IS NULL" 2>&1`
+          GROUP_COUNT=`psql -tA "$CONNECTION_URL" -c "SELECT COUNT(*) FROM groups WHERE group_id='${{ env.GROUP }}' " 2>&1`
           if [[ $? -ne 0 || $GROUP_COUNT -ne 1 ]]; then
             echo "number of groups with group_id = ${{ env.GROUP }} not equal to 1"
             echo "matching number of groups: $GROUP_COUNT"
             exit 1
           fi
-          UPDATED_COUNT=`psql -tA "$CONNECTION_URL" -c "UPDATE groups SET deleted_at=NOW() WHERE group_id = '${{ env.GROUP }}' AND deleted_at IS NULL" 2>&1`
-          if [[ $? -ne 0 || $UPDATED_COUNT != "UPDATE 1" ]]; then
-            echo "group deletion command failed"
-            echo "deletion command results: $UPDATED_COUNT"
+          DELETED_COUNT=`psql -tA "$CONNECTION_URL" -c "DELETE FROM groups WHERE group_id='${{ env.GROUP }}' " 2>&1`
+          if [[ $? -ne 0 || $DELETED_COUNT != "DELETE 1" ]]; then
+            echo "group deletion command failed; DELETED_COUNT does not match expected result"
+            echo "deletion command results: $DELETED_COUNT"
             exit 1
           fi

.github/workflows/cclf-import-deploy.yml

@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build cclf-import zip file
         env:
           CGO_ENABLED: 0

.github/workflows/ci-checks.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Get Go # TEMP
         uses: actions/setup-go@v5
         with:
-          go-version: '>=1.23.1'
+          go-version-file: 'go.mod'
       - name: Tidy modules
         run: |
           go mod tidy -v
@@ -49,15 +49,15 @@ jobs:
     name: Lint and Test
     runs-on: codebuild-bcda-app-${{github.run_id}}-${{github.run_attempt}}
     steps:
-      - name: Get Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: '>=1.23.1'
       - name: Checkout code
         uses: actions/checkout@v4
         with:
           repository: CMSgov/bcda-app
           ref: ${{ env.RELEASE_VERSION }}
+      - name: Get Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
       - name: Install Ansible
         run: |
           sudo yum update -y

.github/workflows/migrate-db.yml

@@ -57,7 +57,7 @@ jobs:
       - name: Get Go
         uses: actions/setup-go@v5
         with:
-          go-version: '>=1.23.6'
+          go-version-file: 'go.mod'
       - name: Get golang-migrate
         run: go install -tags 'postgres' github.com/golang-migrate/migrate/v4/cmd/migrate@latest
       - name: Migrate DB

.github/workflows/opt-out-import-deploy.yml

@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-            go-version: '1.23.1'
+          go-version-file: 'go.mod'
       - name: Build opt-out-import zip file
         env:
           CGO_ENABLED: 0

.pre-commit-config.yaml

@@ -3,8 +3,8 @@ repos:
     rev: v8.19.2
     hooks:
       - id: gitleaks
-  - repo: https://github.com/tekwizely/pre-commit-golang
-    rev: v1.0.0-rc.1
+  - repo: https://github.com/golangci/golangci-lint
+    rev: v2.2.1
     hooks:
-      - id: golangci-lint-pkg
-        args: ['--new', '-v']
+      - id: golangci-lint
+        args: ['--new', '-v', '--fast-only']