committing copilot changes for now to compare later

Author: bwang-icf

client/Dockerfile

@@ -13,10 +13,10 @@ COPY . .
 
 # In case machine is Mac M1 chip
 RUN node --version
-RUN yarn install
+RUN npm ci --legacy-peer-deps
 # comment build out if not going to use preview to save build time
-RUN yarn build
+RUN npm run build
 
 EXPOSE 3000
 
-CMD ["sh", "-c", "yarn $BB2_APP_LAUNCH"]
+CMD ["sh", "-c", "npm run $BB2_APP_LAUNCH"]

client/eslint.config.mjs

@@ -13,5 +13,5 @@ const compat = new FlatCompat({
 });
 
 export default [{
-    ignores: [],
+    ignores: ['build.ts', 'src/configs/config.ts'],
 }, ...fixupConfigRules(compat.extends("react-app"))];

client/package.json

@@ -29,12 +29,7 @@
     "test": "TEST_APP_API_URL=http://localhost:3000 vitest",
     "coverage": "TEST_APP_API_URL=http://localhost:3000 vitest run --coverage"
   },
-  "eslintConfig": {
-    "extends": [
-      "react-app",
-      "react-app/jest"
-    ]
-  },
+  
   "browserslist": {
     "production": [
       ">0.2%",
@@ -48,18 +43,18 @@
     ]
   },
   "devDependencies": {
-    "@eslint/compat": "^1.2.3",
+    "@eslint/compat": "^1.4.0",
     "@testing-library/jest-dom": "^5.16.5",
     "@testing-library/react": "^13.4.0",
     "@testing-library/user-event": "^13.5.0",
     "@types/jest": "^29.1.2",
     "@types/react-router-dom": "^5.3.3",
-    "@typescript-eslint/eslint-plugin": "^5.12.0",
-    "@typescript-eslint/parser": "^5.12.0",
+    "@typescript-eslint/eslint-plugin": "^8.44.1",
+    "@typescript-eslint/parser": "^8.44.1",
     "@vitest/coverage-v8": "2.1.6",
-    "eslint": "^9.16.0",
+    "eslint": "^9.36.0",
     "eslint-config-react-app": "^7.0.1",
-    "eslint-plugin-react": "^7.28.0",
+    "eslint-plugin-react": "^7.37.5",
     "jsdom": "^25.0.1",
     "react-error-overlay": "6.0.9",
     "vite": "^6.0.0",

client/yarn.lock

@@ -9,8 +9,8 @@ COPY . .
 
 # In case machine is Mac M1 chip
 RUN node --version
-RUN yarn install
+RUN npm ci --legacy-peer-deps
 
 EXPOSE 3001
 
-CMD ["yarn","start:debug"]
+CMD ["npm","run","start:debug"]

server/.eslintignore

@@ -0,0 +1,40 @@
+import { fixupConfigRules } from '@eslint/compat';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all
+});
+
+export default [
+  {
+    ignores: ['build.ts', 'src/configs/config.ts'],
+  },
+  ...fixupConfigRules(compat.extends('eslint:recommended', 'plugin:@typescript-eslint/recommended', 'plugin:@typescript-eslint/recommended-requiring-type-checking')),
+  {
+    languageOptions: {
+      parser: await import('@typescript-eslint/parser').then(m => m.default || m),
+      parserOptions: {
+        project: './tsconfig.json'
+      }
+    },
+    rules: {
+      'max-len': ['error', { code: 100 }],
+      'no-console': 1,
+      'no-extra-boolean-cast': 0,
+      '@typescript-eslint/restrict-plus-operands': 0,
+      '@typescript-eslint/explicit-module-boundary-types': 0,
+      '@typescript-eslint/no-explicit-any': 0,
+      '@typescript-eslint/no-floating-promises': 0,
+      '@typescript-eslint/no-unsafe-member-access': 0,
+      '@typescript-eslint/no-unsafe-assignment': 0,
+      '@typescript-eslint/no-unsafe-call': 0
+    }
+  }
+];

server/Dockerfile

@@ -79,18 +79,18 @@ app.get("/api/bluebutton/callback", (req: Request, res: Response) => {
               loggedInUser.authToken = authToken;
 
               loggedInUser.eobData = eobResults.response?.data;
-            } catch (e) {
+              } catch (e) {
               loggedInUser.eobData = {};
               process.stdout.write(ERR_QUERY_EOB + '\n');
-              process.stdout.write("Exception: " + e + '\n');
+              process.stderr.write("Exception: " + String(e) + '\n');
             }
           } else {
             clearBB2Data();
             process.stdout.write(ERR_MISSING_AUTH_CODE + '\n');
             process.stdout.write("OR" + '\n');
             process.stdout.write(ERR_MISSING_STATE + '\n');
-            process.stdout.write("AUTH CODE: " + req.query.code + '\n');
-            process.stdout.write("STATE: " + req.query.state + '\n');
+            process.stdout.write("AUTH CODE: " + JSON.stringify(req.query.code) + '\n');
+            process.stdout.write("STATE: " + JSON.stringify(req.query.state) + '\n');
           }
         }
         const fe_redirect_url = 
@@ -110,12 +110,12 @@ function loadDataFile(dataset_name: string, resource_file_name: string): any {
     const filename = `./default_datasets/${dataset_name}/${resource_file_name}.json`
     const resource = fs.readFileSync(filename, 'utf-8')
 
-    try {
-        return JSON.parse(resource);
-    } catch (error) {
-        process.stdout.write("Error parsing JSON:", error);
-        return null
-    }
+  try {
+    return JSON.parse(resource);
+  } catch (error) {
+    process.stderr.write("Error parsing JSON: " + String(error) + '\n');
+    return null
+  }
 }
 
 // data flow: front end fetch eob

server/eslint.config.mjs

@@ -9,54 +9,22 @@
         "start": "node ./node_modules/.bin/ts-node -r tsconfig-paths/register .",
         "start:debug": "node --inspect=0.0.0.0:9229 ./node_modules/.bin/ts-node -r tsconfig-paths/register ."
     },
-    "eslintConfig": {
-        "parser": "@typescript-eslint/parser",
-        "plugins": [
-            "@typescript-eslint"
-        ],
-        "extends": [
-            "eslint:recommended",
-            "plugin:@typescript-eslint/recommended",
-            "plugin:@typescript-eslint/recommended-requiring-type-checking"
-        ],
-        "parserOptions": {
-            "project": "./tsconfig.json"
-        },
-        "rules": {
-            "max-len": [
-                "error",
-                {
-                    "code": 100
-                }
-            ],
-            "no-console": 1,
-            "no-extra-boolean-cast": 0,
-            "@typescript-eslint/restrict-plus-operands": 0,
-            "@typescript-eslint/explicit-module-boundary-types": 0,
-            "@typescript-eslint/no-explicit-any": 0,
-            "@typescript-eslint/no-floating-promises": 0,
-            "@typescript-eslint/no-unsafe-member-access": 0,
-            "@typescript-eslint/no-unsafe-assignment": 0,
-            "@typescript-eslint/no-unsafe-call": 0
-        }
-    },
-    "eslintIgnore": [
-        "build.ts"
-    ],
+    
     "dependencies": {
         "@types/express": "^4.17.14",
-        "cms-bluebutton-sdk": "^1.0.2",
+        "cms-bluebutton-sdk": "file:./cms-bluebutton-sdk-1.0.4.tgz",
         "express": "^4.18.2",
         "ts-node": "^10.9.1",
         "typescript": "^4.9.3"
     },
     "devDependencies": {
-        "@typescript-eslint/eslint-plugin": "^4.22.0",
-        "@typescript-eslint/parser": "^4.22.0",
-        "eslint": "^7.25.0",
+        "@eslint/compat": "^1.4.0",
+        "@typescript-eslint/eslint-plugin": "^8.44.1",
+        "@typescript-eslint/parser": "^8.44.1",
+        "eslint": "^9.36.0",
         "eslint-config-airbnb": "^19.0.4",
-        "eslint-config-airbnb-typescript": "^16.1.0",
-        "eslint-plugin-import": "^2.25.4",
+        "eslint-config-airbnb-typescript": "^18.0.0",
+        "eslint-plugin-import": "^2.32.0",
         "jest": "^29.3.1",
         "tsconfig-paths": "^4.1.0"
     }