Updates based on PR self-review with Brandon and Matt

Author: JamesDemeryNava

apps/mymedicare_cb/tests/mock_url_responses_slsx.py

@@ -59,9 +59,6 @@ def slsx_signout_fail2_mock(self, url, request):
     # mock sls token endpoint OK
     @urlmatch(netloc=NETLOC_REGEX_SSO_SESSION, path='/sso/session')
     def slsx_token_mock(self, url, request):
-        print()
-        print("slsx_token_mock url: ", url)
-        print("slsx_token_mock request: ", request.__dict__)
         return {"status_code": status.HTTP_200_OK,
                 "content": {"auth_token": "tqXFB/j2OR9Fx7aDowGasMZGqoWmwcihNzMdaW2gpEmV",
                             "role": "consumer",

apps/mymedicare_cb/tests/test_callback_slsx.py

@@ -302,15 +302,10 @@ def catchall(url, request):
             )
             s.save()
 
-            print()
-            print("callback_url: ", self.callback_url)
-            print("THIS IS BEFORE")
             response = self.client.get(
                 self.callback_url,
                 data={"req_token": "0000-test_req_token-0000", "relay": state},
             )
-            print("THIS IS AFTER THE GET")
-            print("response", response.__dict__)
 
             # assert http redirect
             self.assertEqual(response.status_code, status.HTTP_302_FOUND)
@@ -658,7 +653,6 @@ def catchall(url, request):
             response = self.client.get(
                 self.callback_url, data={"req_token": "test", "relay": state}
             )
-            print()
             # assert http redirect
             self.assertEqual(response.status_code, status.HTTP_302_FOUND)
 

hhs_oauth_server/request_logging.py

@@ -157,6 +157,7 @@ def _log_msg_update_from_object(self, obj, key, obj_key):
         # Log message update from a passed in object
         try:
             value = getattr(obj, obj_key, None)
+            # Added as the fhir_id column on crosswalk is now a method rather than a property
             if callable(value):
                 value = value()
             if value is not None: