BB2-1110: Fix for issue discovered during deployment of r165/r166. En… (#1411)

* BB2-1110: Fix for issue discovered during deployment of r165/r166. Ensure /health still returns a 200

* Remove print

Author: JamesDemeryNava

apps/health/urls.py

@@ -1,4 +1,4 @@
-from django.urls import re_path
+from django.urls import path, re_path
 from .views import (
     CheckBFD,
     CheckDB,
@@ -9,11 +9,12 @@
 
 
 urlpatterns = [
-    re_path(r"external/?$", CheckExternal.as_view()),
-    re_path(r"external_v2/?$", CheckExternal.as_view()),
-    re_path(r"sls/?$", CheckSLSX.as_view()),
-    re_path(r"db/?$", CheckDB.as_view()),
-    re_path(r"bfd/?$", CheckBFD.as_view()),
-    re_path(r"bfd_v2/?$", CheckBFD.as_view()),
+    re_path(r"/external/?$", CheckExternal.as_view()),
+    re_path(r"/external_v2/?$", CheckExternal.as_view()),
+    re_path(r"/sls/?$", CheckSLSX.as_view()),
+    re_path(r"/db/?$", CheckDB.as_view()),
+    re_path(r"/bfd/?$", CheckBFD.as_view()),
+    re_path(r"/bfd_v2/?$", CheckBFD.as_view()),
     re_path(r"^$", CheckInternal.as_view()),
+    path("/", CheckInternal.as_view()),
 ]

apps/integration_tests/integration_test_fhir_resources.py

@@ -166,7 +166,7 @@ def _stats_resource_by_type(self, bundle_json, cur_stats_dict, schema=None):
     def test_health_endpoint(self):
         client = APIClient()
         # no authenticate needed
-        response = client.get(self.live_server_url + "/health/")
+        response = client.get(self.live_server_url + "/health")
         self.assertEqual(response.status_code, 200)
         content = json.loads(response.content)
         msg = None

hhs_oauth_server/urls.py

@@ -33,7 +33,7 @@ def robots_txt(request):
 
 
 urlpatterns_unversioned = [
-    path("health/", include("apps.health.urls")),
+    path("health", include("apps.health.urls")),
     path("docs/", include("apps.docs.urls")),
     re_path(r"^" + ADMIN_REDIRECTOR + "admin/metrics/", include("apps.metrics.urls")),
     re_path(r"^" + ADMIN_REDIRECTOR + "admin/", admin.site.urls),