Skip to content

Conversation

@stiwarisemanticbits
Copy link
Contributor

@stiwarisemanticbits stiwarisemanticbits commented Nov 22, 2024

JIRA Ticket:
BB2-3470

What Does This PR Do?

Currently when user authorizes on swagger UI and on consent screens if they click on cancel then UI shows blank page.
This PR redirects back to swagger UI page on cancel

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

  1. Start web server locally
  2. Go to http://localhost:8000/
  3. Click on API Reference
  4. On Swagger UI page, Click on Authorize, and enter relevant details and click on Authorize
  5. Enter medicare.gov login credentials
  6. On Authorization screen, click on cancel instead of continue
  7. It should be redirected to Swagger UI page. Before this PR it was showing blank page

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@jimmyfagan jimmyfagan self-assigned this Nov 22, 2024
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it works as expected. Looks good to me!

@stiwarisemanticbits stiwarisemanticbits merged commit 2333f50 into master Nov 25, 2024
6 checks passed
@stiwarisemanticbits stiwarisemanticbits deleted the st/BB2-3470-openapi branch November 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants