Cleaning up commented out overrides.

Author: jscott-nava

terraform/modules/service/main.tf

@@ -1,6 +1,4 @@
 locals {
-  # awslogs_group     = var.awslogs_group_override != null ? var.awslogs_group_override : local.service_name
-  # container_name    = var.container_name_override != null ? var.container_name_override : local.service_name
   service_name      = var.service_name_override != null ? var.service_name_override : var.platform.service
   service_name_full = "${var.platform.app}-${var.platform.env}-${local.service_name}"
 }
@@ -15,7 +13,6 @@ resource "aws_ecs_task_definition" "this" {
   memory                   = var.memory
   container_definitions = nonsensitive(jsonencode([
     {
-      # name                   = local.container_name
       name                   = local.service_name
       image                  = var.image
       readonlyRootFilesystem = true
@@ -26,7 +23,6 @@ resource "aws_ecs_task_definition" "this" {
       logConfiguration = {
         logDriver = "awslogs"
         options = {
-          # awslogs-group         = "/aws/ecs/fargate/${var.platform.app}-${var.platform.env}/${local.awslogs_group}"
           awslogs-group         = "/aws/ecs/fargate/${var.platform.app}-${var.platform.env}/${local.service_name}"
           awslogs-create-group  = "true"
           awslogs-region        = var.platform.primary_region.name

terraform/modules/service/variables.tf

@@ -1,9 +1,3 @@
-# variable "awslogs_group_override" {
-#   default     = null
-#   description = "Override to allow to non-standard log group names that do not match the service name."
-#   type        = string
-# }
-
 variable "cluster_arn" {
   description = "The ecs cluster ARN hosting the service and task."
   type        = string
@@ -18,12 +12,6 @@ variable "container_environment" {
   default = null
 }
 
-# variable "container_name_override" {
-#   default     = null
-#   description = "Override to allow for non-standard container names that do not match the service name."
-#   type        = string
-# }
-
 variable "container_secrets" {
   description = "The secrets to pass to the container. For more information, see [Specifying Sensitive Data](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/specifying-sensitive-data.html) in the Amazon Elastic Container Service Developer Guide"
   type = list(object({