From e04bcee8ae04f7abc80af259e93c388700b71f94 Mon Sep 17 00:00:00 2001 From: Jonathan Hutchison Date: Thu, 19 Feb 2026 16:46:02 -0500 Subject: [PATCH 1/3] Update card component heading. Remove margin-right from card heading buttons --- dpc-portal/app/components/core/card/basic_component.rb | 5 ++++- .../page/credential_delegate/list_component.html.erb | 2 +- .../page/organization/credentials_component.html.erb | 6 +++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/dpc-portal/app/components/core/card/basic_component.rb b/dpc-portal/app/components/core/card/basic_component.rb index 1de518d088..e6c4427b7b 100644 --- a/dpc-portal/app/components/core/card/basic_component.rb +++ b/dpc-portal/app/components/core/card/basic_component.rb @@ -9,7 +9,10 @@ class BasicComponent < ViewComponent::Base def initialize(text_content: '

Welcome

', button_params: nil) super @text_content = text_content - @button_params = button_params + @button_params = button_params&.merge({ + class: ['usa-button', button_params[:class]].join(' ').strip + }) + end end end diff --git a/dpc-portal/app/components/page/credential_delegate/list_component.html.erb b/dpc-portal/app/components/page/credential_delegate/list_component.html.erb index c46c724aee..a29905ae91 100644 --- a/dpc-portal/app/components/page/credential_delegate/list_component.html.erb +++ b/dpc-portal/app/components/page/credential_delegate/list_component.html.erb @@ -15,7 +15,7 @@ <% end %> <%= render(Core::Card::BasicComponent.new(text_content: '

Invites

', - button_params: { name: 'Invite CD', path: new_organization_credential_delegate_invitation_path(@organization.path_id), method: :get} )) do %> + button_params: { name: 'Invite CD', path: new_organization_credential_delegate_invitation_path(@organization.path_id), class: 'margin-0'} )) do %>

You can invite users to be Credential Delegates.

Pending invites

diff --git a/dpc-portal/app/components/page/organization/credentials_component.html.erb b/dpc-portal/app/components/page/organization/credentials_component.html.erb index 770cdb0106..4c37f83748 100644 --- a/dpc-portal/app/components/page/organization/credentials_component.html.erb +++ b/dpc-portal/app/components/page/organization/credentials_component.html.erb @@ -1,6 +1,6 @@
<%= render(Core::Card::BasicComponent.new(text_content: '

Client tokens

', - button_params: { name: 'Generate token', path: new_organization_client_token_path(@organization.path_id)} )) do %> + button_params: { name: 'Generate token', path: new_organization_client_token_path(@organization.path_id)}, class: 'margin-0' )) do %>

Client tokens monitor who's accessing the API with your organization credentials.

<% if @organization.client_tokens.present? %> @@ -17,7 +17,7 @@
<% end %> <%= render(Core::Card::BasicComponent.new(text_content: '

Public keys

', - button_params: { name: 'Add key', path: new_organization_public_key_path(@organization.path_id) } )) do %> + button_params: { name: 'Add key', path: new_organization_public_key_path(@organization.path_id), class: 'margin-0' } )) do %>

Public keys verify that client token requests come from an authorized application.

<% if @organization.public_keys.present? %> @@ -35,7 +35,7 @@ <% end %> <%= render(Core::Card::BasicComponent.new(text_content: '

Public IP addresses

', - button_params: { name: 'Add IP', path: new_organization_ip_address_path(@organization.path_id)} )) do %> + button_params: { name: 'Add IP', path: new_organization_ip_address_path(@organization.path_id), class: 'margin-0'} )) do %>

Provide a maximum of 8 public IP addresses associated with systems that will access claims data.

<% if @organization.public_ips.present? %> From 01e9576e54f7957a200ab631816890637d733813 Mon Sep 17 00:00:00 2001 From: Jonathan Hutchison Date: Fri, 6 Mar 2026 14:43:58 -0500 Subject: [PATCH 2/3] Update for links --- dpc-portal/app/components/core/card/basic_component.html.erb | 2 +- dpc-portal/app/components/core/card/basic_component.rb | 5 ++--- .../page/organization/credentials_component.html.erb | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/dpc-portal/app/components/core/card/basic_component.html.erb b/dpc-portal/app/components/core/card/basic_component.html.erb index f674194a1a..0f3512bad6 100644 --- a/dpc-portal/app/components/core/card/basic_component.html.erb +++ b/dpc-portal/app/components/core/card/basic_component.html.erb @@ -6,7 +6,7 @@
<% if @button_params %> - <%= link_to @button_params[:name], @button_params[:path], class: 'usa-button' %> + <%= link_to @button_params[:name], @button_params[:path], class: @button_params[:class] %> <% end %>
diff --git a/dpc-portal/app/components/core/card/basic_component.rb b/dpc-portal/app/components/core/card/basic_component.rb index e6c4427b7b..ea917a4b2c 100644 --- a/dpc-portal/app/components/core/card/basic_component.rb +++ b/dpc-portal/app/components/core/card/basic_component.rb @@ -10,9 +10,8 @@ def initialize(text_content: '

Welcome

', button_params: nil) super @text_content = text_content @button_params = button_params&.merge({ - class: ['usa-button', button_params[:class]].join(' ').strip - }) - + class: ['usa-button', button_params[:class]].join(' ').strip + }) end end end diff --git a/dpc-portal/app/components/page/organization/credentials_component.html.erb b/dpc-portal/app/components/page/organization/credentials_component.html.erb index 4c37f83748..cf13fdb5c2 100644 --- a/dpc-portal/app/components/page/organization/credentials_component.html.erb +++ b/dpc-portal/app/components/page/organization/credentials_component.html.erb @@ -1,6 +1,6 @@
<%= render(Core::Card::BasicComponent.new(text_content: '

Client tokens

', - button_params: { name: 'Generate token', path: new_organization_client_token_path(@organization.path_id)}, class: 'margin-0' )) do %> + button_params: { name: 'Generate token', path: new_organization_client_token_path(@organization.path_id), class: 'margin-0' } )) do %>

Client tokens monitor who's accessing the API with your organization credentials.

<% if @organization.client_tokens.present? %> From 8dd4d86677d02346981b4d70ef85d7f077ff1917 Mon Sep 17 00:00:00 2001 From: Jonathan Hutchison Date: Fri, 6 Mar 2026 16:46:31 -0500 Subject: [PATCH 3/3] Update tests --- .../page/credential_delegate/list_component_spec.rb | 2 +- .../page/organization/credentials_componenent_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dpc-portal/spec/components/page/credential_delegate/list_component_spec.rb b/dpc-portal/spec/components/page/credential_delegate/list_component_spec.rb index 06a1affe0d..13959828ba 100644 --- a/dpc-portal/spec/components/page/credential_delegate/list_component_spec.rb +++ b/dpc-portal/spec/components/page/credential_delegate/list_component_spec.rb @@ -48,7 +48,7 @@

Invites

You can invite users to be Credential Delegates.

diff --git a/dpc-portal/spec/components/page/organization/credentials_componenent_spec.rb b/dpc-portal/spec/components/page/organization/credentials_componenent_spec.rb index 5bf0b8a327..3a2cc0a451 100644 --- a/dpc-portal/spec/components/page/organization/credentials_componenent_spec.rb +++ b/dpc-portal/spec/components/page/organization/credentials_componenent_spec.rb @@ -20,19 +20,19 @@ let(:org) { ComponentSupport::MockOrg.new(0) } it 'Should have Generate token button' do button = <<~BUTTON - Generate token + Generate token BUTTON is_expected.to include(normalize_space(button)) end it 'Should have Create key button' do button = <<~BUTTON - Add key + Add key BUTTON is_expected.to include(normalize_space(button)) end it 'Should have Add IP button' do button = <<~BUTTON - Add IP + Add IP BUTTON is_expected.to include(normalize_space(button)) end