Skip to content

Commit 70977e7

Browse files
committed
added username suggestions in en-US
1 parent a52d5ac commit 70977e7

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

public/language/en-GB/error.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
"invalid-pagination-value": "Invalid pagination value, must be at least %1 and at most %2",
4040

41-
"username-taken": "Username taken",
41+
"username-taken": "Username taken. Maybe try %1",
4242
"email-taken": "Email address is already taken.",
4343
"email-nochange": "The email entered is the same as the email already on file.",
4444
"email-invited": "Email was already invited",

public/language/en-US/error.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"invalid-path": "Invalid path",
3333
"folder-exists": "Folder exists",
3434
"invalid-pagination-value": "Invalid pagination value, must be at least %1 and at most %2",
35-
"username-taken": "Username taken",
35+
"username-taken": "Username taken. Maybe try %1",
3636
"email-taken": "Email address is already taken.",
3737
"email-nochange": "The email entered is the same as the email already on file.",
3838
"email-invited": "Email was already invited",

public/src/client/register.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ define('forum/register', [
121121
username_notify.text('');
122122
const usernameInput = $('#username');
123123
const userslug = slugify(username);
124+
124125
if (username.length < ajaxify.data.minimumUsernameLength || userslug.length < ajaxify.data.minimumUsernameLength) {
125126
showError(usernameInput, username_notify, '[[error:username-too-short]]');
126127
} else if (username.length > ajaxify.data.maximumUsernameLength) {
@@ -135,14 +136,15 @@ define('forum/register', [
135136
if (results.every(obj => obj.status === 'rejected')) {
136137
showSuccess(usernameInput, username_notify, successIcon);
137138
} else {
138-
showError(usernameInput, username_notify, '[[error:username-taken]]');
139+
// This is the specific block we are changing
140+
const suggestedUsername = username + 'suffix';
141+
showError(usernameInput, username_notify, '[[error:username-taken, ' + suggestedUsername + ']]');
139142
}
140143

141144
callback();
142145
});
143146
}
144147
}
145-
146148
function validatePassword(password, password_confirm) {
147149
const passwordInput = $('#password');
148150
const password_notify = $('#password-notify');

0 commit comments

Comments
 (0)