Fix: Added alternative username to use when username is taken#2
Open
Nikash-B wants to merge 1 commit intoCMU-313:mainfrom
Open
Fix: Added alternative username to use when username is taken#2Nikash-B wants to merge 1 commit intoCMU-313:mainfrom
Nikash-B wants to merge 1 commit intoCMU-313:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21594715295Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, users don't see any other usernames to try when the username they tried is taken.
We enabled NodeBB to display an alternative username when the username input during account creation was taken. This enables users to try different usernames.
The primary code changes were modifying the
username-takenstring to also taken in another string, here the username input, inpublic/language/en-US/error.jsonandpublic/src/client/register.jsto insert the username along with the suffix as a potential alternative username that the user could try while creating their account.This PR closes #1.
We can see using the screenshot below that fix is working.