Skip to content

Commit 25d021e

Browse files
Removed all sign warnings
1 parent 02354bb commit 25d021e

24 files changed

+65
-64
lines changed

3rdparty/caffe/include/caffe/blob.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Blob {
5353
void ReshapeLike(const Blob& other);
5454
inline string shape_string() const {
5555
ostringstream stream;
56-
for (int i = 0; i < shape_.size(); ++i) {
56+
for (auto i = 0u; i < shape_.size(); ++i) {
5757
stream << shape_[i] << " ";
5858
}
5959
stream << "(" << count_ << ")";

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,10 @@ ifeq ($(USE_OPENCV), 1)
169169
endif
170170

171171
endif
172-
WARNINGS := -Wall -Wno-sign-compare
172+
##############################
173+
# OpenPose extra code: commented
174+
##############################
175+
# WARNINGS := -Wall -Wno-sign-compare
173176

174177
##############################
175178
# Set build directories

doc/release_notes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,5 +105,6 @@ OpenPose Library - Release Notes
105105
## Current version (future OpenPose 1.0.3)
106106
1. Main improvements:
107107
1. Added how to use keypoint data in `examples/tutorial_wrapper/`.
108+
2. Added flag for warnings of type `-Wsign-compare` and removed in code.
108109
2. Main bugs fixed:
109110
1. Windows version crashing with std::map copy.

examples/tests/wrapperHandFromJsonTest.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ namespace op
185185
{
186186
spWPoses.resize(gpuNumber);
187187
const auto handDetector = std::make_shared<HandDetectorFromTxt>(handGroundTruth);
188-
for (auto gpuId = 0; gpuId < spWPoses.size(); gpuId++)
188+
for (auto gpuId = 0u; gpuId < spWPoses.size(); gpuId++)
189189
{
190190
// Hand detector
191191
// If tracking

include/openpose/filestream/wFaceSaver.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace op
5959
auto& tDatumsNoPtr = *tDatums;
6060
// Record people face keypoint data
6161
std::vector<Array<float>> keypointVector(tDatumsNoPtr.size());
62-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
62+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6363
keypointVector[i] = tDatumsNoPtr[i].faceKeypoints;
6464
const auto fileName = (!tDatumsNoPtr[0].name.empty() ? tDatumsNoPtr[0].name : std::to_string(tDatumsNoPtr[0].id));
6565
spKeypointSaver->saveKeypoints(keypointVector, fileName, "face");

include/openpose/filestream/wHandSaver.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ namespace op
6161
const auto fileName = (!tDatumsNoPtr[0].name.empty() ? tDatumsNoPtr[0].name : std::to_string(tDatumsNoPtr[0].id));
6262
std::vector<Array<float>> keypointVector(tDatumsNoPtr.size());
6363
// Left hand
64-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
64+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6565
keypointVector[i] = tDatumsNoPtr[i].handKeypoints[0];
6666
spKeypointSaver->saveKeypoints(keypointVector, fileName, "hand_left");
6767
// Right hand
68-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
68+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6969
keypointVector[i] = tDatumsNoPtr[i].handKeypoints[1];
7070
spKeypointSaver->saveKeypoints(keypointVector, fileName, "hand_right");
7171
// Profiling speed

include/openpose/filestream/wHeatMapSaver.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace op
5858
auto& tDatumsNoPtr = *tDatums;
5959
// Record image(s) on disk
6060
std::vector<Array<float>> poseHeatMaps(tDatumsNoPtr.size());
61-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
61+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6262
poseHeatMaps[i] = tDatumsNoPtr[i].poseHeatMaps;
6363
const auto fileName = (!tDatumsNoPtr[0].name.empty() ? tDatumsNoPtr[0].name : std::to_string(tDatumsNoPtr[0].id));
6464
spHeatMapSaver->saveHeatMaps(poseHeatMaps, fileName);

include/openpose/filestream/wImageSaver.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace op
5858
auto& tDatumsNoPtr = *tDatums;
5959
// Record image(s) on disk
6060
std::vector<cv::Mat> cvOutputDatas(tDatumsNoPtr.size());
61-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
61+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6262
cvOutputDatas[i] = tDatumsNoPtr[i].cvOutputData;
6363
const auto fileName = (!tDatumsNoPtr[0].name.empty() ? tDatumsNoPtr[0].name : std::to_string(tDatumsNoPtr[0].id));
6464
spImageSaver->saveImages(cvOutputDatas, fileName);

include/openpose/filestream/wKeypointJsonSaver.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace op
5959
const auto baseFileName = (!tDatumFirst.name.empty() ? tDatumFirst.name
6060
: std::to_string(tDatumFirst.id)) + "_keypoints";
6161
const bool humanReadable = true;
62-
for (auto i = 0 ; i < tDatums->size() ; i++)
62+
for (auto i = 0u ; i < tDatums->size() ; i++)
6363
{
6464
const auto& tDatum = (*tDatums)[i];
6565
// const auto fileName = baseFileName;

include/openpose/filestream/wPoseSaver.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace op
5959
auto& tDatumsNoPtr = *tDatums;
6060
// Record people pose keypoint data
6161
std::vector<Array<float>> keypointVector(tDatumsNoPtr.size());
62-
for (auto i = 0; i < tDatumsNoPtr.size(); i++)
62+
for (auto i = 0u; i < tDatumsNoPtr.size(); i++)
6363
keypointVector[i] = tDatumsNoPtr[i].poseKeypoints;
6464
const auto fileName = (!tDatumsNoPtr[0].name.empty() ? tDatumsNoPtr[0].name : std::to_string(tDatumsNoPtr[0].id));
6565
spKeypointSaver->saveKeypoints(keypointVector, fileName, "pose");

0 commit comments

Comments
 (0)