From 721745a6b99697f2517994542c8afab1d4996005 Mon Sep 17 00:00:00 2001 From: Kenneth Moreland Date: Thu, 3 Apr 2025 15:34:32 -0400 Subject: [PATCH] Make hipCUB dependency privacy When compiling with HIP, there is a hipCUB dependency. For reasons, you cannot load the library directly. Instead, we add the include directories to the library. These were declared public, but other projects importing the library would not necessarily have these dependent libraries. Thus, declare them private. They should only be needed when compiling the MGARD library. --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5652501cb2..33b71615b9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -218,9 +218,9 @@ if (MGARD_ENABLE_HIP) # is because different sources require different compilers. So, instead just # grab the include directories. target_include_directories(mgard-library - PUBLIC $ - PUBLIC $ - PUBLIC $ + PRIVATE $ + PRIVATE $ + PRIVATE $ ) endif()