Configure script now also gets the flags for libzmq from pkg-config if available. This fixes an issue encountered on the BNL IC where the linker would prefer the system build rather than the spack build of the library.

Added extra spacing around SPDLOG flags in configure script to prevent incorrect argument concatenation
Added a variant to the spack package (default on) which passes the pkg-config flags to the configure script

Author: giltirn

configure.ac

@@ -25,12 +25,25 @@ if [[ "${no_pkgconfig}" -eq 0 ]]; then
    if [[ $(echo ${SPDLOG_CFLAGS} | grep -c "not found") -eq 1 ]]; then
        AC_MSG_FAILURE(["Cannot find spdlog configuration with pkg-config"])
    fi
-   CXXFLAGS+="${SPDLOG_CFLAGS}"
+   CXXFLAGS+=" ${SPDLOG_CFLAGS} "
    SPDLOG_LDFLAGS=$(pkg-config --libs spdlog 2>&1)
-   LDFLAGS+="${SPDLOG_LDFLAGS}" 
+   LDFLAGS+=" ${SPDLOG_LDFLAGS} " 
    AC_MSG_NOTICE([Retrieved configuration for spdlog from pkg-config])
 fi
 
+#on the IC the incorrect build of zmq is being used despite spack. Here we explicitly set the paths using pkg-config
+if [[ "${no_pkgconfig}" -eq 0 ]]; then
+   ZMQ_CFLAGS=$(pkg-config --cflags libzmq 2>&1)
+   if [[ $(echo ${ZMQ_CFLAGS} | grep -c "not found") -eq 1 ]]; then
+       AC_MSG_FAILURE(["Cannot find libzmq configuration with pkg-config"])
+   fi
+   CXXFLAGS+=" ${ZMQ_CFLAGS} "
+   ZMQ_LDFLAGS=$(pkg-config --libs libzmq 2>&1)
+   LDFLAGS+=" ${ZMQ_LDFLAGS} " 
+   AC_MSG_NOTICE([Retrieved configuration for libzmq from pkg-config])
+fi
+
+
 
 # Check if compiling to generate a coverage report using gcov
 # Once built, run the tests in the install/test directory, then from the build directory run
@@ -198,7 +211,6 @@ if test "x$with_boost" != "x"; then
 fi
 AC_CHECK_HEADERS([boost/math/distributions/normal.hpp], [],    [AC_MSG_ERROR(Boost library is required)])
 
-
 AC_CONFIG_HEADERS([chimbuko_config.h])
 AC_SUBST([PS_FLAGS])
 

spack/repo/chimbuko/packages/chimbuko-performance-analysis/package.py

@@ -18,7 +18,8 @@ class ChimbukoPerformanceAnalysis(AutotoolsPackage):
 
     variant('perf-metric', default=True, description='Build with performance monitoring')
     variant('mpi', default=True, description='Enable building Chimbuko with MPI. If disabled the user must manually provide the rank index to the OAD.')
-    
+    variant('pkg-config', default=True, description='Enable the configuration script to use pkg-config to aid in the configuration of dependencies')
+
     depends_on('mpi', when="+mpi")
     depends_on('cereal')
     depends_on('adios2')
@@ -32,6 +33,7 @@ class ChimbukoPerformanceAnalysis(AutotoolsPackage):
     depends_on('automake', type='build')
     depends_on('libtool',  type='build')
     depends_on('m4',       type='build')
+    depends_on('pkgconfig', when='+pkg-config', type='build')
 
 
     def setup_build_environment(self, env):
@@ -45,5 +47,8 @@ def configure_args(self):
                args.append('--with-perf-metric')
         if '+mpi' not in self.spec:
                args.append('--disable-mpi')
+        if '+pkg-config' in self.spec:
+               args.append('--with-pkg-config')
+
 
         return args