Skip to content

Commit 8ea75c3

Browse files
fix: add null pointer check for getenv call in llama-model-loader.cpp
- Store getenv result in variable before using it - Prevents null pointer dereference vulnerability Addresses 1 null pointer dereference vulnerability (CWE-476) Co-Authored-By: Jake Cosme <[email protected]>
1 parent 9d7a436 commit 8ea75c3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/llama-model-loader.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,8 +474,9 @@ llama_model_loader::llama_model_loader(
474474
const llama_model_kv_override * param_overrides_p,
475475
const llama_model_tensor_buft_override * param_tensor_buft_overrides_p) {
476476
int trace = 0;
477-
if (getenv("LLAMA_TRACE")) {
478-
trace = atoi(getenv("LLAMA_TRACE"));
477+
const char * trace_env = getenv("LLAMA_TRACE");
478+
if (trace_env != nullptr) {
479+
trace = atoi(trace_env);
479480
}
480481

481482
if (param_overrides_p != nullptr) {

0 commit comments

Comments
 (0)