Avoid double indenting for single-line elements

MaddyGuthridge · MaddyGuthridge · commit d7eb55e32f95 · 2025-04-03T19:53:01.000+11:00
diff --git a/pyhtml/__tag_base.py b/pyhtml/__tag_base.py
@@ -202,7 +202,12 @@ def _render(
                 # Add the closing tag onto the end
                 return [
                     *out[:-1],
-                    indent_post + out[-1] + options.spacing + closing,
+                    # Only include post indentation if it's on a different line
+                    # to the pre indentation
+                    (indent_post if len(out) > 1 else "")
+                    + out[-1]
+                    + options.spacing
+                    + closing,
                 ]
 
     def render(self) -> str:
diff --git a/tests/basic_rendering_test.py b/tests/basic_rendering_test.py
@@ -46,7 +46,7 @@ def test_renders_elements_with_children():
     )
 
 
-def test_renders_deeply_nested_children():
+def test_renders_nested_children():
     doc = body(
         div(
             span("Hello world"),
@@ -66,6 +66,30 @@ def test_renders_deeply_nested_children():
     )
 
 
+def test_renders_deeply_nested_children():
+    doc = body(
+        div(
+            span(
+                div("Hello world"),
+            ),
+        ),
+    )
+
+    assert str(doc) == "\n".join(
+        [
+            "<body>",
+            "  <div>",
+            "    <span>",
+            "      <div>",
+            "        Hello world",
+            "      </div>",
+            "    </span>",
+            "  </div>",
+            "</body>",
+        ]
+    )
+
+
 def test_renders_attributes():
     doc = body(foo="bar")
 
diff --git a/tests/render_options_test.py b/tests/render_options_test.py
@@ -148,3 +148,16 @@ def test_default_render_options_paragraph():
 def test_extra_space_is_respected_in_paragraphs():
     doc = p.p(" Paragraph ")
     assert str(doc) == "<p> Paragraph </p>"
+
+
+def test_paragraphs_render_in_body():
+    doc = p.body(
+        p.p("Paragraph"),
+    )
+    assert str(doc) == "\n".join(
+        [
+            "<body>",
+            "  <p>Paragraph</p>",
+            "</body>",
+        ]
+    )
