Skip to content

Commit ec6439d

Browse files
authored
Merge pull request #144 from COS301-SE-2023/hotfix/v0.1.0
Hotfix/v0.1.0 to Main
2 parents 3e8a7f1 + d4cafaa commit ec6439d

40 files changed

+1612
-189
lines changed

.github/workflows/ci-dev.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Development CI
22

33
on:
44
push:
5-
branches: [ feat/* ]
5+
branches: [ feat/*, hotfix/* ]
66
pull_request:
7-
branches: [ dev, feat/* ]
7+
branches: [ dev, feat/*, hotfix/* ]
88
workflow_call:
99

1010
permissions:
@@ -46,7 +46,7 @@ jobs:
4646
run: npx nx run app:lint
4747

4848
- name: Test Workspace
49-
run: npm run test:app:ci
49+
run: npm run test:workspace:ci
5050

5151
- name: Upload Coverage Report
5252
uses: codecov/codecov-action@v3
@@ -55,6 +55,9 @@ jobs:
5555
with:
5656
files: coverage/lcov.info
5757

58+
- name: e2e Test App
59+
run: npm run e2e:app:ci
60+
5861
- name: Build App
5962
run: npm run build:app:dev
6063

.github/workflows/ci-prod.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,17 @@ jobs:
4444
run: npx nx run app:lint
4545

4646
- name: Test Workspace
47-
run: npm run test:app:ci
47+
run: npm run test:workspace:ci
4848

4949
- name: Upload Coverage Report
5050
uses: codecov/codecov-action@v3
5151
env:
5252
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
5353
with:
5454
files: coverage/lcov.info
55+
56+
- name: e2e Test App
57+
run: npm run e2e:app:prod
5558

5659
- name: Build App
5760
run: npm run build:app:prod

apps/api/src/main/java/com/fridgetoplate/api/IngredientController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import org.springframework.beans.factory.annotation.Autowired;
1010
import org.springframework.web.bind.annotation.CrossOrigin;
11-
import org.springframework.web.bind.annotation.CrossOrigin;
1211
import org.springframework.web.bind.annotation.DeleteMapping;
1312
import org.springframework.web.bind.annotation.GetMapping;
1413
import org.springframework.web.bind.annotation.PathVariable;
@@ -23,7 +22,7 @@
2322
import com.fridgetoplate.repository.IngredientRepository;
2423

2524
@RestController
26-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
25+
@CrossOrigin(origins = "*", allowedHeaders = "*", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
2726
@RequestMapping("/ingredients")
2827
public class IngredientController {
2928
@Autowired

apps/api/src/main/java/com/fridgetoplate/api/PreferenceController.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import org.springframework.beans.factory.annotation.Autowired;
66
import org.springframework.web.bind.annotation.CrossOrigin;
7-
import org.springframework.web.bind.annotation.CrossOrigin;
87
import org.springframework.web.bind.annotation.DeleteMapping;
98
import org.springframework.web.bind.annotation.GetMapping;
109
import org.springframework.web.bind.annotation.PathVariable;
@@ -13,14 +12,13 @@
1312
import org.springframework.web.bind.annotation.RequestBody;
1413
import org.springframework.web.bind.annotation.RequestMapping;
1514
import org.springframework.web.bind.annotation.RequestMethod;
16-
import org.springframework.web.bind.annotation.RequestMethod;
1715
import org.springframework.web.bind.annotation.RestController;
1816

1917
import com.fridgetoplate.model.Preference;
2018
import com.fridgetoplate.repository.PreferenceRepository;
2119

2220
@RestController
23-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
21+
@CrossOrigin(origins = "*", allowedHeaders = "*", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
2422
@RequestMapping("/preferences")
2523
public class PreferenceController {
2624
@Autowired

apps/api/src/main/java/com/fridgetoplate/api/ProfileController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
import com.fridgetoplate.repository.ProfileRepository;
1010

1111
@RestController
12-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
13-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
12+
@CrossOrigin(origins = "*", allowedHeaders = "*", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
1413
@RequestMapping("/profiles")
1514

1615
public class ProfileController {

apps/api/src/main/java/com/fridgetoplate/api/RecipeController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.fridgetoplate.model.Recipe;
88

99
@RestController
10-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
10+
@CrossOrigin(origins = "*", allowedHeaders = "*", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.DELETE })
1111
@RequestMapping("/recipes")
1212
public class RecipeController {
1313

apps/api/src/main/java/com/fridgetoplate/api/RecommendController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.fridgetoplate.model.Recipe;
88

99
@RestController
10-
@CrossOrigin(origins = "*", allowedHeaders = "", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT,
10+
@CrossOrigin(origins = "*", allowedHeaders = "*", methods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT,
1111
RequestMethod.DELETE })
1212
@RequestMapping("/recommend")
1313

apps/api/src/main/java/com/fridgetoplate/model/Recipe.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.fridgetoplate.utils.StringArrayConverter;
99
import com.fridgetoplate.utils.IngredientArrayConverter;
1010
import com.fridgetoplate.utils.RecipeStepArrayConverter;
11-
import com.fridgetoplate.utils.RecipeStepArrayConverter;
1211

1312
import lombok.Data;
1413

apps/api/src/main/java/com/fridgetoplate/model/RecipeStep.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import com.fasterxml.jackson.annotation.JsonProperty;
55

66
public class RecipeStep {
7-
@JsonProperty("instructionHead")
8-
private String instructionHead;
7+
@JsonProperty("instructionHeading")
8+
private String instructionHeading = "N/A";
99

1010
@JsonProperty("instructionBody")
1111
private String instructionBody;

apps/api/src/main/java/com/fridgetoplate/repository/IngredientRepository.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
package com.fridgetoplate.repository;
2-
import java.util.Arrays;
32
import java.util.List;
43
import org.springframework.beans.factory.annotation.Autowired;
54
import org.springframework.stereotype.Repository;

0 commit comments

Comments
 (0)