Skip to content

Commit 9b4da96

Browse files
Young-Jae ChoshubhamshahaBMW
authored andcommitted
Remove dead code / commander projectfile loading.
Can be easily added if needed, but showing it customer facing without value is misleading and as such removed the dead code to make onboarding / maintenance easier.
1 parent e164453 commit 9b4da96

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

commander/optmanager.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ QString toString(const Split& split) {
6565

6666
OptManager::OptManager()
6767
{
68-
project = false;
6968
log = false;
7069
convert = false;
7170
filter = false;
@@ -100,10 +99,10 @@ void OptManager::printUsage()
10099
{
101100
QString executable;
102101
#if (WIN32)
103-
qDebug()<<"\nUsage:\n\n dlt-commander.exe [OPTIONS] [logfile] [projectfile] [filterfile] [mf4file] [pcapfile]";
102+
qDebug()<<"\nUsage:\n\n dlt-commander.exe [OPTIONS] [logfile] [filterfile] [mf4file] [pcapfile]";
104103
executable = " dlt-commander.exe";
105104
#else
106-
qDebug()<<"\nUsage:\n\n dlt-commander [OPTIONS] [logfile] [projectfile] [filterfile] [mf4file] [pcapfile]";
105+
qDebug()<<"\nUsage:\n\n dlt-commander [OPTIONS] [logfile] [filterfile] [mf4file] [pcapfile]";
107106
executable = " dlt-commander";
108107
#endif
109108

@@ -235,10 +234,6 @@ void OptManager::parse(QStringList *opt)
235234
const QString logFile = QString("%1").arg(opt->at(i));
236235
logFiles += logFile;
237236
qDebug()<< "DLT filename:" << logFile;
238-
} else if (opt->at(i).endsWith(".dlp") || opt->at(i).endsWith(".DLP")) {
239-
projectFile = QString("%1").arg(opt->at(i));
240-
project = true;
241-
qDebug()<< "Project filename:" << projectFile;
242237
} else if (opt->at(i).endsWith(".dlf") || opt->at(i).endsWith(".DLF")) {
243238
filterFiles += QString("%1").arg(opt->at(i));
244239
qDebug()<< "Filter filename:" << QString("%1").arg(opt->at(i));
@@ -271,7 +266,6 @@ QStringList OptManager::getLogFiles()const {return logFiles;}
271266
QStringList OptManager::getFilterFiles() const {return filterFiles;}
272267
QString OptManager::getConvertSourceFile() const {return convertSourceFile;}
273268
QString OptManager::getConvertDestFile()const {return convertDestFile;}
274-
QString OptManager::getProjectFile() const {return projectFile;}
275269
char OptManager::getDelimiter() const {return delimiter;}
276270
QString OptManager::getSignature() const {return signature;}
277271

commander/optmanager.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ class OptManager
6868
QStringList getFilterFiles() const;
6969
QString getConvertSourceFile() const;
7070
QString getConvertDestFile() const;
71-
QString getProjectFile() const;
7271
char getDelimiter() const;
7372
const std::optional<Split>& getSplit() const;
7473
QString getSignature() const;
@@ -79,7 +78,6 @@ class OptManager
7978
const QStringList &getMf4Files() const;
8079

8180
private:
82-
bool project;
8381
bool log;
8482
bool filter;
8583
bool convert;
@@ -94,7 +92,6 @@ class OptManager
9492
QStringList mf4Files;
9593
QStringList filterFiles;
9694
QStringList prePluginCommands;
97-
QString projectFile;
9895
QString convertSourceFile;
9996
QString convertDestFile;
10097
char delimiter;

0 commit comments

Comments
 (0)