Skip to content

Commit 6529d29

Browse files
authored
[DDING-000] 동아리 회차 타입 수정 (#335)
1 parent ec62e33 commit 6529d29

13 files changed

+19
-20
lines changed

src/main/java/ddingdong/ddingdongBE/domain/activityreport/controller/ClubActivityReportApiController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class ClubActivityReportApiController implements ClubActivityReportApi {
3232
@Override
3333
public CurrentTermResponse getCurrentTerm() {
3434
LocalDateTime now = LocalDateTime.now();
35-
String currentTerm = facadeClubActivityReportService.getCurrentTerm(now);
35+
int currentTerm = facadeClubActivityReportService.getCurrentTerm(now);
3636
return CurrentTermResponse.from(currentTerm);
3737
}
3838

src/main/java/ddingdong/ddingdongBE/domain/activityreport/controller/dto/request/CreateActivityReportRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
public record CreateActivityReportRequest(
1010
@Schema(description = "활동 보고서 회차 정보", example = "1")
11-
String term,
11+
int term,
1212

1313
@Schema(description = "활동 보고서 내용", example = "세션을 진행하였습니다")
1414
String content,

src/main/java/ddingdong/ddingdongBE/domain/activityreport/controller/dto/response/CentralActivityReportListResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public record CentralActivityReportListResponse(
1111
String name,
1212

1313
@Schema(description = "회차", example = "1")
14-
String term,
14+
int term,
1515

1616
@Schema(description = "활동보고서 정보")
1717
List<ActivityReportDto> activityReports

src/main/java/ddingdong/ddingdongBE/domain/activityreport/controller/dto/response/CurrentTermResponse.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
@Builder
77
public record CurrentTermResponse(
88
@Schema(description = "현재 활동 회차", example = "1")
9-
String term
9+
int term
1010
) {
1111

12-
public static CurrentTermResponse from(String term) {
12+
public static CurrentTermResponse from(int term) {
1313
return CurrentTermResponse.builder()
1414
.term(term)
1515
.build();

src/main/java/ddingdong/ddingdongBE/domain/activityreport/entity/ActivityReport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class ActivityReport extends BaseEntity {
3131
@GeneratedValue(strategy = GenerationType.IDENTITY)
3232
private Long id;
3333

34-
private String term;
34+
private int term;
3535

3636
@Column(length = 100)
3737
private String content;
@@ -54,7 +54,7 @@ public class ActivityReport extends BaseEntity {
5454

5555
@Builder
5656
public ActivityReport(
57-
String term,
57+
int term,
5858
String content,
5959
String place,
6060
LocalDateTime startDate,

src/main/java/ddingdong/ddingdongBE/domain/activityreport/service/ActivityReportTermInfoService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ public interface ActivityReportTermInfoService {
1111

1212
void create(LocalDate startDate, int totalTermCount);
1313

14-
String getCurrentTerm(LocalDateTime now);
14+
int getCurrentTerm(LocalDateTime now);
1515
}

src/main/java/ddingdong/ddingdongBE/domain/activityreport/service/ActivityReportTermInfoServiceImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,14 @@ public void create(LocalDate startDate, int totalTermCount) {
4444
}
4545

4646
@Override
47-
public String getCurrentTerm(LocalDateTime now) {
47+
public int getCurrentTerm(LocalDateTime now) {
4848
List<ActivityReportTermInfo> allActivityReportTermInfo = activityReportTermInfoRepository.findAll();
49-
Integer currentTerm = allActivityReportTermInfo.stream()
49+
return allActivityReportTermInfo.stream()
5050
.filter((activityReportTermInfo) -> isBelongingTerm(activityReportTermInfo.getStartDate(),
5151
activityReportTermInfo.getEndDate(), now))
5252
.map(ActivityReportTermInfo::getTerm)
5353
.findFirst()
5454
.orElse(NON_ACTIVITY_REPORT_TERM);
55-
return String.valueOf(currentTerm);
5655
}
5756

5857
private boolean isBelongingTerm(LocalDate startDate, LocalDate endDate, LocalDateTime now) {

src/main/java/ddingdong/ddingdongBE/domain/activityreport/service/FacadeClubActivityReportService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public interface FacadeClubActivityReportService {
1717

1818
List<ActivityReportTermInfoQuery> getActivityReportTermInfos();
1919

20-
String getCurrentTerm(LocalDateTime now);
20+
int getCurrentTerm(LocalDateTime now);
2121

2222
void create(User user, List<CreateActivityReportCommand> commands);
2323

src/main/java/ddingdong/ddingdongBE/domain/activityreport/service/FacadeClubActivityReportServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public List<ActivityReportTermInfoQuery> getActivityReportTermInfos() {
6363
}
6464

6565
@Override
66-
public String getCurrentTerm(LocalDateTime now) {
66+
public int getCurrentTerm(LocalDateTime now) {
6767
return activityReportTermInfoService.getCurrentTerm(now);
6868
}
6969

@@ -132,7 +132,7 @@ private ActivityReportQuery parseToQuery(ActivityReport activityReport) {
132132

133133
private List<CentralActivityReportListQuery> parseToListQuery(String clubName,
134134
List<ActivityReport> activityReports) {
135-
Map<String, List<ActivityReport>> activityReportsGroupedByTerm = activityReports.stream()
135+
Map<Integer, List<ActivityReport>> activityReportsGroupedByTerm = activityReports.stream()
136136
.collect(Collectors.groupingBy(ActivityReport::getTerm));
137137

138138
return activityReportsGroupedByTerm.entrySet().stream()

src/main/java/ddingdong/ddingdongBE/domain/activityreport/service/dto/command/CreateActivityReportCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
@Builder
1111
public record CreateActivityReportCommand(
12-
String term,
12+
int term,
1313
String content,
1414
String place,
1515
String startDate,

0 commit comments

Comments
 (0)