-
Notifications
You must be signed in to change notification settings - Fork 3
TUR-41: Updated Frontend #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… main Updated#
frontend/src/pages/Home/Home.jsx
Outdated
super(props); | ||
} | ||
|
||
// parser(input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all comments
|
||
|
||
|
||
export const Wrapper = styled.body` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change styled.body to styled.div
font-weight: bold; | ||
`; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix your spacing
::placeholder { | ||
font-family: 'Trebuchet MS', sans-serif; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing
text-align: left; | ||
font-family: 'Trebuchet MS', sans-serif; | ||
width: 200px; | ||
padding: 10px 10px; //inside padding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
|
||
|
||
export const Button = styled.button` | ||
/* This renders the buttons above... Edit me! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
text-decoration: none; | ||
height: 100%; | ||
padding: 0px 20px; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure spacing like this is everywhere before a :hover or &something
{auth.isAuthenticated ? ( | ||
<> | ||
<button onClick={logoutUser}>Sign out</button> | ||
<p key={3}>{`Logged in as: You`}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why key?
<img src={logo}/> | ||
</NavLogo> | ||
<Header>Cloud Haven</Header> | ||
<NavItemLocation> | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need empty <>
import Home from '../pages/Home/Home'; | ||
import PrivateRoute from '../components/private-route/PrivateRoute'; | ||
import NewPage from '../components/NewPage/NewPage'; | ||
|
||
|
||
// Check for token to keep user logged in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove da comments
// Redirect to login | ||
window.location.href = './login'; | ||
// Redirect to NewPage, was login | ||
window.location.href = './'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove .
worked on login, register, navbar