fix highlight hiding bug

WiFuchs · WiFuchs · commit 584ebf6c437e · 2021-06-04T14:27:40.000-07:00
diff --git a/src/annotator/highlighter.js b/src/annotator/highlighter.js
@@ -357,6 +357,7 @@ export function setHighlightsFocused(highlights, focused) {
 export function setHighlightsVisible(root, visible) {
   const showHighlightsClass = 'hypothesis-highlights-always-on';
   root.classList.toggle(showHighlightsClass, visible);
+  root.classList.toggle('hypothesis-highlights-hidden', !visible);
 }
 
 /**
diff --git a/src/styles/annotator/highlights.scss b/src/styles/annotator/highlights.scss
@@ -6,6 +6,12 @@
   fill: transparent;
 }
 
+.hypothesis-highlights-hidden {
+  .hypothesis-highlight {
+    background-color: transparent !important;
+  }
+}
+
 // `hypothesis-highlights-always-on` is a class that is toggled on the root
 // of the annotated document when highlights are enabled/disabled.
 .hypothesis-highlights-always-on {

Original file line number	Diff line number	Diff line change
`@@ -357,6 +357,7 @@ export function setHighlightsFocused(highlights, focused) {`
`357`	`357`	`export function setHighlightsVisible(root, visible) {`
`358`	`358`	`const showHighlightsClass = 'hypothesis-highlights-always-on';`
`359`	`359`	`root.classList.toggle(showHighlightsClass, visible);`
	`360`	`+ root.classList.toggle('hypothesis-highlights-hidden', !visible);`
`360`	`361`	`}`
`361`	`362`
`362`	`363`	`/**`