Provide Feedback For Operation Performed

On Performing Operations such as Add Question, Update Question or Delete Question, a boolean value is also returned.

True implies the operation was successfully executed, while False implies otherwise.

Author: Jai2501

peer-prep/src/Components/QuestionList/QuestionList.jsx

@@ -20,30 +20,39 @@ export const Questions = () => {
   const addQuestion = (qTitle, qDifficulty, qTopic, qDescription) => {
     // Add in Database and Upload into Storage
     let newQuestion = new QuestionModel(qId, qTitle, qDescription, qDifficulty, qTopic);
-    database.addQuestion(newQuestion);
+    let isAddedSuccessfully = database.addQuestion(newQuestion);
 
     updateLocalDatabase();
     updateStates();
 
-    // setQs([...qs, {id: qId, title: qTitle, difficulty: qDifficulty,
-    //   topic: qTopic, description: qDescription}]);
+    console.log("Is Additon Successful: " + isAddedSuccessfully);
+
+    return isAddedSuccessfully;
   }
 
   // Delete a Question
   const deleteQuestion = (questionId) => {
-    database.deleteQuestion(questionId);
+    let isDeletedSuccessfully = database.deleteQuestion(questionId);
 
     updateLocalDatabase();
     updateStates();
+
+    console.log("Is Deletion Successful: " + isDeletedSuccessfully);
+
+    return isDeletedSuccessfully;
   }
 
   // Update an existing Question
   const updateQuestion = (qId, qTitle, qDescription, qDifficulty, qTopic) => {
     let updatedQuestion = new QuestionModel(qId, qTitle, qDescription, qDifficulty, qTopic);
-    database.updateQuestion(updatedQuestion);
+    let isUpdateSuccessful = database.updateQuestion(updatedQuestion);
 
     updateLocalDatabase();
     updateStates();
+
+    console.log("Is Update Successful: " + isUpdateSuccessful);
+
+    return isUpdateSuccessful;
   }
 
   const updateLocalDatabase = () => {
@@ -54,7 +63,7 @@ export const Questions = () => {
   const updateStates = () => {
     // Update States
     setQs(Array.from(database.database));
-    setQId(Array.from(database.database).length == 0 ? 0 : Array.from(database.database).sort((a, b) => a[0] < b[0]).slice(-1)[0][0]);
+    setQId(Array.from(database.database).length === 0 ? 0 : Array.from(database.database).sort((a, b) => a[0] < b[0]).slice(-1)[0][0]);
   }
 
   // To load data on mount

peer-prep/src/DataModel/QuestionDatabase.js

@@ -14,19 +14,32 @@ class QuestionDatabase {
     }
 
     addQuestion(questionToAdd) {
-        if (!this.isDuplicateQuestion(questionToAdd)) {
+        if (!this.isDuplicateQuestion(questionToAdd, true)) {
             this.database.set(questionToAdd.id, questionToAdd);
+
+            return true;
         }
+
+        return false
     }
 
     deleteQuestion(questionId) {
         if (this.database.has(questionId)) {
             this.database.delete(questionId);
+
+            return true;
         }
+
+        return false;
     }
 
     updateQuestion(questionToUpdate) {
-        this.database.set(questionToUpdate.id, questionToUpdate);
+        if (!this.isDuplicateQuestion(questionToUpdate, false)) {
+            this.database.set(questionToUpdate.id, questionToUpdate);
+            return true;
+        }
+
+        return false;
     }
 
     getAllQuestions() {
@@ -39,14 +52,19 @@ class QuestionDatabase {
         return questionList;
     }
 
-    isDuplicateQuestion(questionToCheck) {
-        if (this.database.has(questionToCheck.id)) {
+    isDuplicateQuestion(questionToCheck, toCheckId) {
+        // Ensure Unique ID when adding questions
+        if (this.database.has(questionToCheck.id) && toCheckId) {
             return true;
         }
 
         var questionList = this.getAllQuestions();
 
         for (var i = 0; i < questionList.length; i++) {
+            if (questionToCheck.id === questionList[i].id) {
+                continue;
+            }
+
             if (questionToCheck.title === questionList[i].title) {
                 return true;
             }

peer-prep/src/Utility/localStorage.js

@@ -7,7 +7,7 @@ function updateLocalQuestionDatabase(updatedDatabase) {
 
 function retrieveQuestionDatabase() {
     let questionDatabase = new QuestionDatabase();
-    console.log(localStorage.getItem("questions"));
+
     questionDatabase.setDatabase(new Map(JSON.parse(localStorage.getItem("questions"))))
     return questionDatabase;
 }