Skip to content

Commit 38a77e3

Browse files
Merge pull request #145 from PeerPrep/update-users-service
Style fixes
2 parents 20f0fe7 + bc1e3bb commit 38a77e3

File tree

7 files changed

+79
-83
lines changed

7 files changed

+79
-83
lines changed

users/src/activity/list.ts

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
1-
import { Request, Response } from "express"
1+
import { Request, Response } from "express";
22
import { Activity } from "../entities/Activity";
33
import { ApiResponse, StatusMessageType } from "../types";
44

55
export async function listActivityHandler(req: Request, res: Response) {
6-
const em = req.orm.em.fork();
6+
const em = req.orm.em.fork();
77

8-
const uid = req.userToken.uid;
8+
const uid = req.userToken.uid;
99

10-
const activities = await em.find(Activity, { uid: uid });
10+
const activities = await em.find(Activity, { uid: uid });
1111

12-
const response: ApiResponse = {
13-
statusMessage: {
14-
type: StatusMessageType.SUCCESS,
15-
message: "List user activity",
16-
},
17-
payload: activities,
18-
};
12+
const response: ApiResponse = {
13+
statusMessage: {
14+
type: StatusMessageType.SUCCESS,
15+
message: "List user activity",
16+
},
17+
payload: activities,
18+
};
1919

20-
res.send(response);
20+
res.send(response);
2121
}
22-

users/src/activity/update.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export async function updateActivityHandler(req: Request, res: Response) {
1313
const activity = await em.upsert(Activity, {
1414
uid: uid,
1515
questionId: body.questionId,
16-
submitted: new Date()
16+
submitted: new Date(),
1717
});
1818

1919
await em.persistAndFlush(activity);

users/src/admin/index.ts

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Router, Request, Response, NextFunction } from "express"
1+
import { Router, Request, Response, NextFunction } from "express";
22
import { updateRoleHandler } from "./update";
33
import { listProfileHandler } from "./list";
44
import { handleCustomError, handleServerError } from "../utils";
@@ -8,29 +8,25 @@ import { Profile, Role } from "../entities/Profile";
88
const router = Router();
99

1010
router.use(async (req: Request, res: Response, next: NextFunction) => {
11-
const em = req.orm.em.fork();
12-
const uid = req.userToken.uid;
11+
const em = req.orm.em.fork();
12+
const uid = req.userToken.uid;
1313

14-
try {
15-
const profile = await em.findOneOrFail(Profile, {
16-
uid: uid
17-
});
18-
19-
if (profile.role == Role.USER) {
20-
return handleCustomError(
21-
res,
22-
{
23-
type: StatusMessageType.ERROR,
24-
message: "Insufficient Permissions"
25-
}
26-
);
27-
}
28-
29-
next();
14+
try {
15+
const profile = await em.findOneOrFail(Profile, {
16+
uid: uid,
17+
});
3018

31-
} catch (err: any) {
32-
handleServerError(err, res);
19+
if (profile.role == Role.USER) {
20+
return handleCustomError(res, {
21+
type: StatusMessageType.ERROR,
22+
message: "Insufficient Permissions",
23+
});
3324
}
25+
26+
next();
27+
} catch (err: any) {
28+
handleServerError(err, res);
29+
}
3430
});
3531

3632
router.post("/update", updateRoleHandler);

users/src/admin/list.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
import { Request, Response } from "express"
1+
import { Request, Response } from "express";
22
import { Profile } from "../entities/Profile";
33
import { ApiResponse, StatusMessageType } from "../types";
44
import { handleServerError } from "../utils";
55

66
export async function listProfileHandler(req: Request, res: Response) {
7-
const em = req.orm.em.fork();
7+
const em = req.orm.em.fork();
88

9-
try {
10-
const profiles = await em.find(Profile, {});
9+
try {
10+
const profiles = await em.find(Profile, {});
1111

12-
const response: ApiResponse = {
13-
statusMessage: {
14-
message: "Listed profiles successfully",
15-
type: StatusMessageType.SUCCESS,
16-
},
17-
payload: profiles,
18-
};
19-
res.status(200).send(response);
20-
} catch (err: any) {
21-
handleServerError(err, res);
22-
}
12+
const response: ApiResponse = {
13+
statusMessage: {
14+
message: "Listed profiles successfully",
15+
type: StatusMessageType.SUCCESS,
16+
},
17+
payload: profiles,
18+
};
19+
res.status(200).send(response);
20+
} catch (err: any) {
21+
handleServerError(err, res);
22+
}
2323
}

users/src/admin/update.ts

Lines changed: 26 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -4,37 +4,34 @@ import { ApiResponse, StatusMessageType } from "../types";
44
import { handleCustomError, handleServerError } from "../utils";
55

66
export async function updateRoleHandler(req: Request, res: Response) {
7-
const em = req.orm.em.fork();
8-
const body = req.body;
7+
const em = req.orm.em.fork();
8+
const body = req.body;
99

10-
try {
11-
if (body.role !== Role.USER && body.role !== Role.ADMIN) {
12-
return handleCustomError(
13-
res,
14-
{
15-
message: "Invalid role specified",
16-
type: StatusMessageType.ERROR
17-
}
18-
);
19-
}
20-
21-
const loadedProfile = await em.findOneOrFail(Profile, {
22-
uid: body.uid
23-
});
10+
try {
11+
if (body.role !== Role.USER && body.role !== Role.ADMIN) {
12+
return handleCustomError(res, {
13+
message: "Invalid role specified",
14+
type: StatusMessageType.ERROR,
15+
});
16+
}
2417

25-
loadedProfile.role = body.role;
18+
const loadedProfile = await em.findOneOrFail(Profile, {
19+
uid: body.uid,
20+
});
2621

27-
await em.flush();
22+
loadedProfile.role = body.role;
2823

29-
const response: ApiResponse = {
30-
statusMessage: {
31-
message: "Role updated successfully",
32-
type: StatusMessageType.SUCCESS,
33-
},
34-
payload: loadedProfile,
35-
};
36-
res.status(200).send(response);
37-
} catch (err: any) {
38-
handleServerError(err, res);
39-
}
24+
await em.flush();
25+
26+
const response: ApiResponse = {
27+
statusMessage: {
28+
message: "Role updated successfully",
29+
type: StatusMessageType.SUCCESS,
30+
},
31+
payload: loadedProfile,
32+
};
33+
res.status(200).send(response);
34+
} catch (err: any) {
35+
handleServerError(err, res);
36+
}
4037
}

users/src/entities/Profile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class Profile {
2222
@Property({ nullable: true })
2323
imageUrl?: string;
2424

25-
@Enum({ items: () => Language, nullable: true})
25+
@Enum({ items: () => Language, nullable: true })
2626
preferredLang?: Language;
2727

2828
@Enum({ items: () => Role, default: Role.USER })

users/src/index.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Express, { Request, Response, NextFunction } from "express";
22
import { MikroORM, type PostgreSqlDriver } from "@mikro-orm/postgresql";
3-
import "dotenv/config"
3+
import "dotenv/config";
44

55
import { App, applicationDefault, initializeApp } from "firebase-admin/app";
66
import { DecodedIdToken, getAuth } from "firebase-admin/auth";
@@ -44,7 +44,7 @@ initDatabase().then((orm) => {
4444

4545
const firebaseApp = initializeApp({
4646
credential: applicationDefault(),
47-
storageBucket: process.env.BUCKET_NAME
47+
storageBucket: process.env.BUCKET_NAME,
4848
});
4949

5050
const firebaseAuth = getAuth(firebaseApp);
@@ -66,7 +66,11 @@ initDatabase().then((orm) => {
6666
}
6767
};
6868

69-
const injectDependencies = (req: Request, res: Response, next: NextFunction) => {
69+
const injectDependencies = (
70+
req: Request,
71+
res: Response,
72+
next: NextFunction
73+
) => {
7074
req.orm = orm;
7175
req.firebaseApp = firebaseApp;
7276
next();

0 commit comments

Comments
 (0)