Merge pull request #180 from PeerPrep/elroy-final-bugfixes

fix: fix logical bugs

Author: sivayogasubramanian

frontend/src/app/components/modal/QuestionModal.tsx

@@ -31,6 +31,14 @@ const triggerQuestionIdUpdateRequestAtom = atom(
 const QuestionModal = () => {
   const questionId = useAtomValue(questionIdAtom);
   const [isOpen, setIsOpen] = useAtom(isQuestionModalOpenAtom);
+  const [selectedQn, setSelectedQn] =
+    useState<SingleValue<SelectedOptionType>>();
+
+  const handleSelectChange = (
+    selectedOption: SingleValue<SelectedOptionType>,
+  ) => {
+    setSelectedQn(selectedOption);
+  };
 
   const [questions, setQuestions] = useState<QuestionType[]>([]);
   const setCollabQuestion = useSetAtom(triggerQuestionIdUpdateRequestAtom);
@@ -47,13 +55,11 @@ const QuestionModal = () => {
         }),
       );
     });
+    if (questionId === "") {
+      setIsOpen(true);
+    }
   }, []);
 
-  // setQuestions(
-  //   questions.filter(
-  //   }),
-  // );
-
   const options: SelectedOptionType[] = questions.map((question, i) => {
     return {
       label: question.title as string,
@@ -75,15 +81,6 @@ const QuestionModal = () => {
       break;
   }
 
-  const [selectedQn, setSelectedQn] =
-    useState<SingleValue<SelectedOptionType>>();
-
-  const handleSelectChange = (
-    selectedOption: SingleValue<SelectedOptionType>,
-  ) => {
-    setSelectedQn(selectedOption);
-  };
-
   const onClickStart = () => {
     setIsOpen(false);
     if (selectedQn) {
@@ -103,7 +100,7 @@ const QuestionModal = () => {
       <input
         type="checkbox"
         onChange={() => undefined}
-        checked={isOpen || questionId === ""}
+        checked={isOpen}
         className="modal-toggle"
       />
       <dialog id="question-modal" className="modal">

frontend/src/app/components/status-bar/StatusBar.tsx

@@ -63,7 +63,7 @@ const StatusBar = ({ exitMethod }: StatusBarProps) => {
   };
 
   return (
-    <footer className="fixed bottom-0 left-0 flex w-[100svw] items-center justify-between border-black bg-primary px-4 py-2 shadow-sm lg:static lg:w-full lg:px-12">
+    <footer className="fixed bottom-0 left-0 flex w-[100svw] items-center justify-between border-black bg-primary px-4 py-2 shadow-sm lg:w-full lg:px-12">
       {contextHolder}
       <div className="flex gap-4">
         {userStates &&