Merge pull request #128 from CS3219-AY2425S1/cloud-fix

fix docker file for session service

Author: simbayippy

session-service/Dockerfile

@@ -8,8 +8,9 @@ RUN npm install -g pnpm
 WORKDIR /app
 
 # Copy package.json and pnpm-lock.yaml
-COPY package.json ./
+COPY package.json pnpm-lock.yaml ./
 
+# Install all dependencies
 RUN pnpm install
 
 # Development stage
@@ -28,13 +29,13 @@ FROM base AS production
 ENV NODE_ENV=production
 ENV PORT=4444
 
-# Install typescript for production build
-RUN npm install -g typescript
-RUN pnpm add -D typescript
-
+# Copy source files
 COPY src ./src
 COPY tsconfig.json ./
 
+# Build the TypeScript code
+RUN pnpm build
+
 EXPOSE ${PORT}
 
 CMD ["pnpm", "start"]

session-service/package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "dev": "nodemon src/server.ts",
     "start": "tsc && node dist/server.js",
-    "build": "tsc",
+    "build": "tsc && echo \"Build completed successfully.\"",
     "format": "prettier --write \"src/**/*.ts\"",
     "pre-commit": "pnpm format && git add -u",
     "test": "echo \"Error: no test specified\" && exit 1"
@@ -25,6 +25,7 @@
     "y-websocket": "^2.0.4"
   },
   "devDependencies": {
-    "@types/ws": "^8.5.12"
+    "@types/ws": "^8.5.12",
+    "typescript": "^5.6.3"
   }
 }

session-service/pnpm-lock.yaml

@@ -46,7 +46,7 @@ function onListening() {
 httpServer.on("error", onError);
 httpServer.on("listening", onListening);
 
-const PORT = process.env.PORT; // or any port you prefer
+const PORT = process.env.PORT || 4444; // fallback to 4444 if PORT env var is not set
 
 httpServer.listen(PORT, () => {
   console.log(`Server is running on ${PORT}`);