Skip to content

Commit 45db24a

Browse files
authored
Merge pull request #55 from CS3219-AY2425S1/fix/production-endpoints
Fix/production endpoints
2 parents 095660d + 7a30651 commit 45db24a

File tree

4 files changed

+30
-1
lines changed

4 files changed

+30
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,9 @@ jobs:
2828
run: "gcloud info"
2929

3030
- name: "Trigger Cloud Build"
31-
run: "gcloud builds submit --config cloudbuild.yaml"
31+
env:
32+
NEXT_PUBLIC_QUESTION_SERVICE_URL: ${{ secrets.NEXT_PUBLIC_QUESTION_SERVICE_URL }}
33+
NEXT_PUBLIC_AUTH_SERVICE_URL: ${{ secrets.NEXT_PUBLIC_AUTH_SERVICE_URL }}
34+
run: |
35+
gcloud builds submit --config cloudbuild.yaml \
36+
--substitutions _NEXT_PUBLIC_QUESTION_SERVICE_URL=$NEXT_PUBLIC_QUESTION_SERVICE_URL,_NEXT_PUBLIC_AUTH_SERVICE_URL=$NEXT_PUBLIC_AUTH_SERVICE_URL

cloudbuild.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ steps:
88
"build",
99
"-t",
1010
"asia-southeast1-docker.pkg.dev/cs3219-g11-peerprep/cs3219-g11-repo/peerprep-fe:latest",
11+
"--build-arg",
12+
"NEXT_PUBLIC_QUESTION_SERVICE_URL=${_NEXT_PUBLIC_QUESTION_SERVICE_URL}",
13+
"--build-arg",
14+
"NEXT_PUBLIC_AUTH_SERVICE_URL=${_NEXT_PUBLIC_AUTH_SERVICE_URL}",
1115
"-f",
1216
"peerprep-fe/Dockerfile",
1317
"peerprep-fe",
@@ -137,6 +141,10 @@ steps:
137141
- "CLOUDSDK_COMPUTE_ZONE=asia-southeast1"
138142
- "CLOUDSDK_CONTAINER_CLUSTER=cs3219-g11-peerprep-kubes"
139143

144+
substitutions:
145+
_NEXT_PUBLIC_QUESTION_SERVICE_URL: ""
146+
_NEXT_PUBLIC_AUTH_SERVICE_URL: ""
147+
140148
options:
141149
dynamic_substitutions: true
142150

k8s/peerprep-config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: v1
2+
kind: Secret
3+
metadata:
4+
name: peerprep-config
5+
type: Opaque
6+
stringData:
7+
NEXT_PUBLIC_QUESTION_SERVICE_URL: "${_NEXT_PUBLIC_QUESTION_SERVICE_URL}"
8+
NEXT_PUBLIC_AUTH_SERVICE_URL: "${_NEXT_PUBLIC_AUTH_SERVICE_URL}"

peerprep-fe/Dockerfile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ FROM base AS production
3030
ENV NODE_ENV=production
3131
ENV PORT=3000
3232

33+
# Accept build arguments
34+
ARG NEXT_PUBLIC_QUESTION_SERVICE_URL
35+
ARG NEXT_PUBLIC_AUTH_SERVICE_URL
36+
37+
# Set environment variables
38+
ENV NEXT_PUBLIC_QUESTION_SERVICE_URL=$NEXT_PUBLIC_QUESTION_SERVICE_URL
39+
ENV NEXT_PUBLIC_AUTH_SERVICE_URL=$NEXT_PUBLIC_AUTH_SERVICE_URL
40+
3341
COPY . .
3442
RUN pnpm build
3543

0 commit comments

Comments
 (0)