Skip to content

Commit b606f09

Browse files
authored
Merge pull request #120 from CS3219-AY2425S1/cloud-fix
add tsc to docker
2 parents 0956c86 + db8b08e commit b606f09

File tree

1 file changed

+40
-15
lines changed

1 file changed

+40
-15
lines changed

session-service/Dockerfile

Lines changed: 40 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,61 @@
1-
# Base stage for both dev and prod
2-
FROM node:18-alpine AS base
1+
# Build stage
2+
FROM node:18-alpine AS builder
33

44
# Install pnpm globally
55
RUN npm install -g pnpm
66

7-
# Set the working directory in the container
87
WORKDIR /app
98

10-
# Copy package.json and pnpm-lock.yaml
9+
# Copy package files
1110
COPY package.json ./
1211

12+
# Install all dependencies (including devDependencies)
1313
RUN pnpm install
1414

15-
# Development stage
16-
FROM base AS development
17-
15+
# Copy source code and tsconfig
1816
COPY src ./src
1917
COPY tsconfig.json ./
2018

21-
# Note: Don't expose ports here, Compose will handle that for us
22-
23-
CMD ["pnpm", "dev"]
24-
19+
# Build the TypeScript code
20+
RUN pnpm build
2521

2622
# Production stage
27-
FROM base AS production
23+
FROM node:18-alpine AS production
2824
ENV NODE_ENV=production
2925
ENV PORT=4444
3026

31-
COPY src ./src
32-
COPY tsconfig.json ./
27+
# Install pnpm globally
28+
RUN npm install -g pnpm
29+
30+
WORKDIR /app
31+
32+
# Copy package files
33+
COPY package.json ./
34+
35+
# Install only production dependencies
36+
RUN pnpm install --prod
37+
38+
# Copy built files from builder stage
39+
COPY --from=builder /app/dist ./dist
3340

3441
EXPOSE ${PORT}
3542

36-
CMD ["pnpm", "start"]
43+
# Run the compiled JavaScript
44+
CMD ["node", "dist/server.js"]
45+
46+
# Development stage
47+
FROM node:18-alpine AS development
48+
49+
# Install pnpm globally
50+
RUN npm install -g pnpm
51+
52+
WORKDIR /app
53+
54+
COPY package.json ./
55+
56+
RUN pnpm install
57+
58+
COPY src ./src
59+
COPY tsconfig.json ./
60+
61+
CMD ["pnpm", "dev"]

0 commit comments

Comments
 (0)