Add pagination to /all request

Select only necessary fields for /{id} and /all requests
Edit test for /all

Author: jehousoh

backend/question/src/models/Question.ts

@@ -9,7 +9,7 @@ import mongooseAutoIncrement from "mongoose-sequence";
 export type TQuestion = {
   title: string;
   description: string;
-  category: string;
+  category: [string];
   complexity: string;
 };
 

backend/question/src/routes/questionRoutes.ts

@@ -43,12 +43,34 @@ router.post(
 
 // Retrieve all questions
 router.get("/all", async (req: Request, res: Response) => {
+  const pagination = parseInt(req.body.pagination as string, 10) || 1; // Default page is 1
+  const page_size = parseInt(req.body.page_size as string, 10) || 10; // Default limit is 10
+  const skip = (pagination - 1) * page_size; // Calculate how many documents to skip
   try {
-    const questions = await Question.find()
+    const questions = await Question.find(
+      {},
+      {
+        questionid: 1,
+        title: 1,
+        description: 1,
+        complexity: 1,
+        category: 1,
+      }
+    )
       .lean()
       .sort({ questionid: "ascending" })
+      .skip(skip)
+      .limit(page_size)
       .exec();
-    return res.json(questions);
+
+    const total = await Question.countDocuments().exec();
+
+    return res.json({
+      questions,
+      currentPage: pagination,
+      totalPages: Math.ceil(total / page_size),
+      totalQuestions: total,
+    });
   } catch (error) {
     return res.status(500).send("Internal server error");
   }
@@ -62,7 +84,10 @@ router.get("/:id", [...idValidators], async (req: Request, res: Response) => {
   }
   const questionId = parseInt(req.params.id, 10);
   try {
-    const question = await Question.findOne({ questionid: questionId }).exec();
+    const question = await Question.findOne(
+      { questionid: questionId },
+      { questionid: 1, title: 1, description: 1, complexity: 1, category: 1 }
+    ).exec();
     if (!question) {
       return res.status(404).json({ message: "Question not found" });
     }

backend/question/src/tests/app.spec.ts

@@ -97,7 +97,9 @@ describe("Test Question API", () => {
 
     const res = await request.post("/api/create").send(newQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
     expect(res.body.errors[0].path).toBe("category");
   });
 
@@ -172,7 +174,9 @@ describe("Test Question API", () => {
 
     const res = await request.post("/api/create").send(newQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
     expect(res.body.errors[0].path).toBe("category");
   });
 
@@ -187,7 +191,9 @@ describe("Test Question API", () => {
 
     const res = await request.post("/api/create").send(newQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
     expect(res.body.errors[0].path).toBe("category");
   });
 
@@ -202,7 +208,9 @@ describe("Test Question API", () => {
 
     const res = await request.post("/api/create").send(newQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
     expect(res.body.errors[0].path).toBe("category");
   });
 
@@ -227,10 +235,13 @@ describe("Test Get All", () => {
   // Get all with questions
   test("GET /api/all - should retrieve all questions", async () => {
     const res = await request.get("/api/all").send();
-    const sampleQuestion = res.body[0];
+    const sampleQuestion = res.body.questions[0];
     expect(res.statusCode).toBe(200);
-    expect(Array.isArray(res.body)).toBe(true);
-    expect(res.body.length).toBe(1);
+    expect(Array.isArray(res.body.questions)).toBe(true);
+    expect(res.body.questions.length).toBe(1);
+    expect(res.body.currentPage).toBe(1);
+    expect(res.body.totalPages).toBe(1);
+    expect(res.body.totalQuestions).toBe(1);
     expect(sampleQuestion).toHaveProperty("title", "Sample Question");
     expect(sampleQuestion).toHaveProperty(
       "description",
@@ -326,7 +337,7 @@ describe("Test Update", () => {
   // Update with invalid category
   test("POST - empty category", async () => {
     const updateQuestion = {
-      category: []
+      category: [],
     };
     const questionId = 1090;
     const res = await request
@@ -347,7 +358,9 @@ describe("Test Update", () => {
       .post(`/api/${questionId}/update`)
       .send(updateQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
   });
 
   // Update with invalid category
@@ -362,7 +375,9 @@ describe("Test Update", () => {
       .post(`/api/${questionId}/update`)
       .send(updateQuestion);
     expect(res.statusCode).toBe(400);
-    expect(res.body.errors[0].msg).toBe("Category must contain only non-empty strings");
+    expect(res.body.errors[0].msg).toBe(
+      "Category must contain only non-empty strings"
+    );
   });
 
   // Negative id