Skip to content

Commit 02b9a80

Browse files
authored
Merge pull request #57 from CS3219-AY2425S1/ben/misc-collab
Integrate miscellaneous features for collaboration feature
2 parents ba383ad + 5fdbaa8 commit 02b9a80

File tree

9 files changed

+543
-250
lines changed

9 files changed

+543
-250
lines changed

.github/workflows/test.yml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@ jobs:
3030
USER_SERVICE_URL: ${{ vars.USER_SERVICE_URL }}
3131
MATCHING_SERVICE_URL: ${{ vars.MATCHING_SERVICE_URL }}
3232
HISTORY_SERVICE_URL: ${{ vars.HISTORY_SERVICE_URL }}
33+
SIGNALLING_SERVICE_URL: ${{ vars.SIGNALLING_SERVICE_URL }}
3334
JWT_SECRET: ${{ secrets.JWT_SECRET }}
3435
QUESTION_FIREBASE_CREDENTIAL_PATH: ${{ vars.QUESTION_SERVICE_FIREBASE_CREDENTIAL_PATH }}
3536
HISTORY_FIREBASE_CREDENTIAL_PATH: ${{ vars.HISTORY_SERVICE_FIREBASE_CREDENTIAL_PATH }}
3637
DB_CLOUD_URI: ${{ secrets.USER_SERVICE_DB_CLOUD_URI }}
3738
USER_SERVICE_PORT: ${{ vars.USER_SERVICE_PORT }}
3839
MATCHING_SERVICE_PORT: ${{ vars.MATCHING_SERVICE_PORT }}
3940
HISTORY_SERVICE_PORT: ${{ vars.HISTORY_SERVICE_PORT }}
41+
SIGNALLING_SERVICE_PORT: ${{ vars.SIGNALLING_SERVICE_PORT }}
4042
MATCHING_SERVICE_TIMEOUT: ${{ vars.MATCHING_SERVICE_TIMEOUT }}
4143
REDIS_URL: ${{ vars.REDIS_URL }}
4244
QUESTION_SERVICE_GRPC_URL: ${{ vars.QUESTION_SERVICE_GPRC_URL }}
@@ -46,6 +48,7 @@ jobs:
4648
echo "NEXT_PUBLIC_USER_SERVICE_URL=$USER_SERVICE_URL" >> .env
4749
echo "NEXT_PUBLIC_MATCHING_SERVICE_URL=$MATCHING_SERVICE_URL" >> .env
4850
echo "NEXT_PUBLIC_HISTORY_SERVICE_URL=$HISTORY_SERVICE_URL" >> .env
51+
echo "NEXT_PUBLIC_SIGNALLING_SERVICE_URL=$SIGNALLING_SERVICE_URL" >> .env
4952
5053
cd ../question-service
5154
echo "FIREBASE_CREDENTIAL_PATH=$QUESTION_FIREBASE_CREDENTIAL_PATH" >> .env
@@ -67,6 +70,9 @@ jobs:
6770
echo "FIREBASE_CREDENTIAL_PATH=$HISTORY_FIREBASE_CREDENTIAL_PATH" >> .env
6871
echo "PORT=$HISTORY_SERVICE_PORT" >> .env
6972
73+
cd ../signalling-service
74+
echo "PORT=$SIGNALLING_SERVICE_PORT" >> .env
75+
7076
- name: Create Database Credential Files
7177
env:
7278
QUESTION_FIREBASE_JSON: ${{ secrets.QUESTION_SERVICE_FIREBASE_CREDENTIAL }}
@@ -101,6 +107,7 @@ jobs:
101107
QUESTION_SERVICE_URL: ${{ vars.QUESTION_SERVICE_URL }}
102108
MATCHING_SERVICE_URL: ${{ vars.MATCHING_SERVICE_URL }}
103109
HISTORY_SERVICE_URL: ${{ vars.HISTORY_SERVICE_URL }}
110+
SIGNALLING_SERVICE_URL: ${{ vars.SIGNALLING_SERVICE_URL }}
104111
run: |
105112
echo "Testing Question Service..."
106113
curl -sSL -o /dev/null $QUESTION_SERVICE_URL && echo "Question Service is up"
@@ -117,5 +124,10 @@ jobs:
117124
echo "WebSocket for Matching Service is live"
118125
fi
119126
# Add in test for matching service in the future
120-
127+
echo "Testing Signalling Service..."
128+
if ! (echo "Hello" | websocat $SIGNALLING_SERVICE_URL); then
129+
echo "WebSocket for Signalling Service is not live"
130+
else
131+
echo "WebSocket for Signalling Service is live"
132+
fi
121133
# We can add more tests here

apps/docker-compose.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ services:
1111
- ./frontend/.env
1212
volumes:
1313
- ./frontend:/frontend
14+
depends_on:
15+
- signalling-service
1416

1517
user-service:
1618
build:
@@ -66,6 +68,19 @@ services:
6668
- apps_network
6769
volumes:
6870
- ./history-service:/history-service
71+
72+
signalling-service:
73+
build:
74+
context: ./signalling-service
75+
dockerfile: Dockerfile
76+
ports:
77+
- 4444:4444
78+
env_file:
79+
- ./signalling-service/.env
80+
networks:
81+
- apps_network
82+
volumes:
83+
- ./signalling-service:/signalling-service
6984

7085
redis:
7186
image: redis:latest

0 commit comments

Comments
 (0)