Skip to content

Commit b03c71b

Browse files
Merge pull request #31 from CS3219-AY2425S1/titus/setup-docker-compose
fix: readme for docker
2 parents a428a91 + e326646 commit b03c71b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

apps/frontend/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ You can start editing the page by modifying `app/page.tsx`. The page auto-update
4242
# Navigate to the frontend app directory
4343
cd apps/frontend
4444
# Build dockerfile (Ensure that your docker daemon is running beforehand)
45-
docker build -t frontend -e NEXT_PUBLIC_QUESTION_SERVICE_URL="http://localhost:8080/" -f Dockerfile .
45+
docker build -t frontend -f Dockerfile .
4646
```
4747

4848
Run the backend server locally and visit http://localhost:3000/ to see the frontend application working
@@ -51,7 +51,7 @@ Run the backend server locally and visit http://localhost:3000/ to see the front
5151

5252
```sh
5353
# Run the docker image, the -d tag is to run it detached
54-
docker run -p 3000:3000 -d frontend
54+
docker run -p 3000:3000 -d frontend -e NEXT_PUBLIC_QUESTION_SERVICE_URL="http://localhost:8080/"
5555

5656
# To see the running container
5757
docker ps

apps/user-service/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@
287287
# Navigate to the user-service app directory
288288
cd apps/user-service
289289
# Build dockerfile after replacing the build arguments (Ensure that your docker daemon is running beforehand)
290-
docker build -t user-service --build-arg JWT_TOKEN='replace_with_jwt_token' --build-arg DB_CLOUD_URI='replace_with_db_uri_here' -f Dockerfile .
290+
docker build -t user-service --build-arg JWT_SECRET='replace_with_jwt_secret' --build-arg DB_CLOUD_URI='replace_with_db_uri_here' -f Dockerfile .
291291
```
292292

293293
### Running Docker

0 commit comments

Comments
 (0)