merge n11

Author: chiaryan

.github/workflows/test.yml

@@ -43,15 +43,16 @@ jobs:
         with: 
           go-version: '1.23.x'
 
-      - name: Install dependencies
+      - name: Install Go dependencies
         run: |
           cd ./apps/question-service
           go mod tidy
 
-      - name: Run tests
-        run: |
-          cd ./apps/question-service
-          go test ./...
+      - name: Install firebase tools
+        run: curl -sL firebase.tools | bash
+      
+      - name: Run Go tests with Firebase emulator
+        run: firebase emulators:exec --only firestore 'cd ./apps/question-service'
 
   frontend-unit-tests:
     runs-on: ubuntu-latest
@@ -83,7 +84,7 @@ jobs:
           cd ./apps/frontend
           pnpm test
 
-  test:
+  test-docker-compose:
     runs-on: ubuntu-latest
 
     steps:

apps/question-service/tests/read_test.go

@@ -2,74 +2,74 @@ package tests
 
 import (
 	"context"
-	"fmt"
 	"log"
 	"net/http"
 	"net/http/httptest"
 	"os"
-	"path/filepath"
 	"question-service/handlers"
+	"question-service/utils"
 	"strings"
 	"testing"
 
 	"cloud.google.com/go/firestore"
-	firebase "firebase.google.com/go/v4"
 	"github.com/go-chi/chi/v5"
-	"github.com/joho/godotenv"
-	"google.golang.org/api/option"
 )
 
 var service *handlers.Service
+var ctx = context.Background()
 
-func createService() *handlers.Service {
-
-	ctx := context.Background()
-	client, err := initFirestore(ctx)
-
+func TestMain(m *testing.M) {
+	// Set FIRESTORE_EMULATOR_HOST environment variable.
+	err := os.Setenv("FIRESTORE_EMULATOR_HOST", "localhost:8080")
 	if err != nil {
-		log.Fatalf("failed to initialize Firestore: %v", err)
+		log.Fatalf("could not set env %v", err)
 	}
+	// Create client.
+	client, err := firestore.NewClient(ctx, "my-project-id")
+	service = &handlers.Service{Client: client}
 
-	return &handlers.Service{Client: client}
-}
-
-// initFirestore initializes the Firestore client
-func initFirestore(ctx context.Context) (*firestore.Client, error) {
-	credentialsPath := "../" + os.Getenv("FIREBASE_CREDENTIAL_PATH")
-	opt := option.WithCredentialsFile(credentialsPath)
-	app, err := firebase.NewApp(ctx, nil, opt)
 	if err != nil {
-		return nil, fmt.Errorf("failed to initialize Firebase App: %v", err)
+		log.Fatalf("could not create client %v", err)
 	}
+	defer client.Close()
 
-	client, err := app.Firestore(ctx)
-	if err != nil {
-		return nil, fmt.Errorf("failed to get Firestore client: %v", err)
-	}
-	return client, nil
+	m.Run()
+	os.Exit(0)
 }
 
-func TestMain(m *testing.M) {
-	err := godotenv.Load(filepath.Join("../", ".env"))
+// Sets up the firestore emulator with the sample questions
+// This repopulates the db
+// Returns the docref of one of the questions if a test need it
+func setupDb(t *testing.T) string {
+	// Repopulate document
+	utils.Populate(service.Client)
+
+	coll := service.Client.Collection("questions")
+	if coll == nil {
+		t.Fatalf("Failed to get CollectionRef")
+	}
+	docRef, err := coll.DocumentRefs(ctx).Next()
 	if err != nil {
-		log.Fatalf("Error loading .env file")
+		t.Fatalf("Failed to get DocRef: %v", err)
 	}
-	service = createService()
-	defer service.Client.Close()
-	exitCode := m.Run()
-	os.Exit(exitCode)
+	return docRef.ID
 }
 
-func Test_Read(t *testing.T) {
-	res := httptest.NewRecorder()
-
+func ReadRequestWithId(id string) *http.Request {
 	// adds chi context
 	// https://stackoverflow.com/questions/54580582/testing-chi-routes-w-path-variables
 	rctx := chi.NewRouteContext()
-	rctx.URLParams.Add("docRefID", "6SdbW4Awcfm5x0UQtWmg")
+	rctx.URLParams.Add("docRefID", id)
 
-	req := httptest.NewRequest(http.MethodGet, "http://localhost:8080/questions/6SdbW4Awcfm5x0UQtWmg", strings.NewReader(""))
+	req := httptest.NewRequest(http.MethodGet, "http://localhost:12345/questions/"+id, strings.NewReader(""))
 	req = req.WithContext(context.WithValue(req.Context(), chi.RouteCtxKey, rctx))
+	return req
+}
+func Test_Read(t *testing.T) {
+	id := setupDb(t)
+
+	res := httptest.NewRecorder()
+	req := ReadRequestWithId(id)
 
 	service.ReadQuestion(res, req)
 
@@ -79,19 +79,15 @@ func Test_Read(t *testing.T) {
 }
 
 func Test_ReadNotFound(t *testing.T) {
-	res := httptest.NewRecorder()
-
-	// adds chi context
-	// https://stackoverflow.com/questions/54580582/testing-chi-routes-w-path-variables
-	rctx := chi.NewRouteContext()
-	rctx.URLParams.Add("docRefID", "not-found-docref")
+	setupDb(t)
 
-	req := httptest.NewRequest(http.MethodGet, "http://localhost:8080/questions/not-found-docref", strings.NewReader(""))
-	req = req.WithContext(context.WithValue(req.Context(), chi.RouteCtxKey, rctx))
+	res := httptest.NewRecorder()
+	req := ReadRequestWithId("invalid-docref")
 
 	service.ReadQuestion(res, req)
 
 	if res.Result().StatusCode != 404 {
 		t.Fatalf("expected status code 404 but got response %v", res.Result())
 	}
+
 }