Skip to content

Commit 1cd8dd0

Browse files
committed
Fix Improper Error Catching and Incorrect Uniqueness Check
1 parent e10ef3b commit 1cd8dd0

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

backend/question-service/models/HistoryEntry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface HistoryEntry extends mongoose.Document {
1515
const historyEntrySchema: Schema = new Schema<HistoryEntry>({
1616
userId: { type: String, required: true },
1717
question: { type: Schema.Types.ObjectId, ref: 'question', required: true },
18-
roomId: { type: String, required: true },
18+
roomId: { type: String, required: true, unique: false },
1919
attemptStartedAt: { type: Date, required: true, default: Date.now() },
2020
attemptCompletedAt: { type: Date, required: true, default: Date.now() },
2121
collaboratorId: { type: String, required: true },

frontend/src/data/repositories/HistoryRemoteDataSource.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ export class HistoryRemoteDataSource extends BaseApi {
1818
}
1919

2020
async deleteSelectedHistories(selectedHistoryIds: string[]): Promise<void> {
21+
console.log("Delete")
2122
selectedHistoryIds.forEach(async (id) => {
23+
console.log(id);
2224
await this.delete<void>(`/user/${id}`);
2325
});
2426
}

frontend/src/domain/usecases/HistoryUseCases.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class HistoryUseCases {
3838
* @throws Error if selectedHistoryIds is of length 0 or contains an empty _id.
3939
*/
4040
async deleteSelectedUserHistories(selectedHistoryIds: string[]): Promise<void> {
41-
if (selectedHistoryIds.length === 0 || !selectedHistoryIds.every((_id) => (!_id || _id.trim() === ""))) {
41+
if (selectedHistoryIds.length === 0 || selectedHistoryIds.find((_id) => (!_id || _id.trim() === ""))) {
4242
throw new Error("History ID must be provided");
4343
}
4444
await this.historyRepository.deleteSelectedUserHistories(selectedHistoryIds);

0 commit comments

Comments
 (0)