Rename attemptCompletedAt field to lastSubmittedAttemptAt

Author: Nephelite

backend/question-service/controllers/historyController.ts

@@ -23,7 +23,7 @@ export const getUserHistoryEntries = async (req: any, res: Response) => {
         key: entry._id,
         roomId: entry.roomId,
         attemptStartedAt: entry.attemptStartedAt.getTime(),
-        attemptCompletedAt: entry.attemptCompletedAt.getTime(),
+        lastAttemptSubmittedAt: entry.lastAttemptSubmittedAt.getTime(),
         title: entry.question.title,
         difficulty: entry.question.difficulty,
         topics: entry.question.categories.map((cat: any) => cat.name),
@@ -48,10 +48,10 @@ export const createOrUpdateUserHistoryEntry = async (req: any, res: Response) =>
 
     const existingEntry = await historyEntryModel.findOne({ userId, roomId });
 
-    if (!isInitial && existingEntry) {
+    if (!isInitial && existingEntry && attemptCode && attemptCode !== "") {
       existingEntry.question = questionId;
       existingEntry.attemptStartedAt = attemptStartedAt;
-      existingEntry.attemptCompletedAt = attemptCompletedAt;
+      existingEntry.lastAttemptSubmittedAt = attemptCompletedAt;
       existingEntry.collaboratorId = collaboratorId;
       existingEntry.attemptCodes.push(attemptCode);
 

backend/question-service/models/HistoryEntry.ts

@@ -7,7 +7,7 @@ export interface HistoryEntry extends mongoose.Document {
   question: Question;
   roomId: string; // Note: This should not be used to retrieve the room from matching service! This is only here to serve as a uniqueness check for updating attempt information!
   attemptStartedAt: Date;
-  attemptCompletedAt: Date;
+  lastAttemptSubmittedAt: Date;
   collaboratorId: string;
   attemptCodes: string[];
 }
@@ -17,7 +17,7 @@ const historyEntrySchema: Schema = new Schema<HistoryEntry>({
   question: { type: Schema.Types.ObjectId, ref: 'question', required: true },
   roomId: { type: String, required: true, unique: false },
   attemptStartedAt: { type: Date, required: true, default: Date.now() },
-  attemptCompletedAt: { type: Date, required: true, default: Date.now() },
+  lastAttemptSubmittedAt: { type: Date, required: true, default: Date.now() },
   collaboratorId: { type: String, required: true },
   attemptCodes: [{ type: String }],
 });

frontend/src/domain/entities/HistoryEntry.ts

@@ -3,7 +3,7 @@ export interface HistoryEntry {
     key: string;
     roomId: string;
     attemptStartedAt: string;
-    attemptCompletedAt: string;
+    lastAttemptSubmittedAt: string;
     title: string;
     difficulty: 'Easy' | 'Medium' | 'Hard';
     topics: string[];

frontend/src/presentation/components/RecentAttemptsTable.tsx

@@ -139,11 +139,11 @@ export const RecentAttemptsTable: React.FC = () => {
       title: 'Date',
       dataIndex: 'date',
       key: 'date',
-      sorter: (a, b) => new Date(a.attemptCompletedAt).getTime() - new Date(b.attemptCompletedAt).getTime(),
+      sorter: (a, b) => new Date(a.lastAttemptSubmittedAt).getTime() - new Date(b.lastAttemptSubmittedAt).getTime(),
       render: (_text, record) => {
         const formattedStartDate = formatDate(record.attemptStartedAt);
-        const formattedEndDate = formatDate(record.attemptCompletedAt);
-        const duration = calculateDuration(record.attemptStartedAt, record.attemptCompletedAt);
+        const formattedEndDate = formatDate(record.lastAttemptSubmittedAt);
+        const duration = calculateDuration(record.attemptStartedAt, record.lastAttemptSubmittedAt);
         return (
           <div className={styles.dateContainer}>
             <div>
@@ -279,7 +279,6 @@ export const RecentAttemptsTable: React.FC = () => {
           </Button>,
         ]}
         width={900}
-        bodyStyle={{ padding: 0 }}
       >
         {currentCodes.length > 0 ? (
           <Tabs