Move Responsibility of Checking Room Expiry to Question Service

Author: Nephelite

backend/question-service/controllers/historyController.ts

@@ -18,10 +18,15 @@ export const getUserHistoryEntries = async (req: any, res: Response) => {
       },
     });
     const historyViewModels = historyEntries.map((entry) => {
+      const attemptStartDate = new Date(entry.attemptStartedAt);
+      const timeDiffMs = Date.now() - attemptStartDate.getTime();
+
+      const isWithin24Hours = timeDiffMs < 86400000; // 1 Day; Same as ROOM_LIFESPAN in MatchingService. Can be different if desired.
+
       return {
         id: entry._id,
         key: entry._id,
-        roomId: entry.roomId,
+        roomId: isWithin24Hours ? entry.roomId : null,
         attemptStartedAt: entry.attemptStartedAt.getTime(),
         lastAttemptSubmittedAt: entry.lastAttemptSubmittedAt.getTime(),
         title: entry.question.title,

frontend/src/domain/entities/HistoryEntry.ts

@@ -1,7 +1,7 @@
 export interface HistoryEntry {
     _id: string;
     key: string;
-    roomId: string;
+    roomId?: string; // If null, room is expired
     attemptStartedAt: string;
     lastAttemptSubmittedAt: string;
     title: string;

frontend/src/presentation/components/RecentAttemptsTable.tsx

@@ -208,36 +208,28 @@ export const RecentAttemptsTable: React.FC = () => {
     {
       title: 'Actions',
       key: 'action',
-      render: (_text, record) => {
-        const attemptStartDate = new Date(record.attemptStartedAt);
-        const now = new Date();
-        const timeDiffMs = now.getTime() - attemptStartDate.getTime();
-
-        const isWithin24Hours = timeDiffMs < 86400000; // Should be same as ROOM_LIFESPAN in MatchingService
-
-        return (
-          <Space size="middle" className={styles.actionsButton}>
+      render: (_text, record) => (
+        <Space size="middle" className={styles.actionsButton}>
+          <Button
+            type="link"
+            onClick={() => showModal(record.attemptCodes, record.key)}
+            icon={<EyeOutlined />}
+            aria-label={`View past code for attempt ${record.key}`}
+          >
+            View Past Code
+          </Button>
+          {record.roomId && (
             <Button
               type="link"
-              onClick={() => showModal(record.attemptCodes, record.key)}
-              icon={<EyeOutlined />}
-              aria-label={`View past code for attempt ${record.key}`}
+              onClick={() => navigate(`/room/${record.roomId}`)}
+              icon={<TeamOutlined />}
+              aria-label={`Rejoin room ${record.roomId}`}
             >
-              View Past Code
+              Rejoin
             </Button>
-            {isWithin24Hours && (
-              <Button
-                type="link"
-                onClick={() => navigate(`/room/${record.roomId}`)}
-                icon={<TeamOutlined />}
-                aria-label={`Rejoin room ${record.roomId}`}
-              >
-                Rejoin
-              </Button>
-            )}
-          </Space>
-        );
-      },
+          )}
+        </Space>
+      ),
     },
   ];