Merge pull request #116 from CS3219-AY2425S1/delete-history-entries-on-missing-question-and-categories

Add History Deletion on Question Deletion

Author: njxue

backend/question-service/controllers/historyController.ts

@@ -17,7 +17,15 @@ export const getUserHistoryEntries = async (req: any, res: Response) => {
         model: "category",
       },
     });
-    const historyViewModels = historyEntries.map((entry) => {
+
+    historyEntries.forEach(async (entry) => {
+      if (entry.question === null) {
+        await historyEntryModel.findByIdAndDelete({_id: entry._id});
+      }
+    })
+    const historyViewModels = historyEntries
+    .filter((entry) => !(entry.question === null))
+    .map((entry) => {
       return {
         id: entry._id,
         key: entry._id,

backend/question-service/controllers/questionsController.ts

@@ -4,6 +4,7 @@ import { Request, Response, NextFunction } from "express";
 import { EachMessagePayload } from "kafkajs";
 import { producer, QUESTION_TOPIC } from "../utils/kafkaClient";
 import { Types } from "mongoose";
+import historyEntryModel from "../models/HistoryEntry";
 
 const DIFFICULTIES = ["easy", "medium", "hard"];
 
@@ -143,6 +144,7 @@ export async function deleteQuestion(
     const { id } = request.params;
 
     try {
+        await historyEntryModel.deleteMany({ question: id });
         const deletedQuestion = await questionModel.findOneAndDelete({
             _id: id,
         });