Merge pull request #70 from guanquann/frontend/lint

Fix frontend lint issues

Author: nicolelim02

frontend/src/components/NoDirectAccessRoutes/index.tsx

@@ -1,18 +1,4 @@
-import { Navigate, Outlet, useLocation, useNavigate } from "react-router-dom";
-import React from "react";
-
-export const useAppNavigate = () => {
-  const navigate = useNavigate();
-
-  const appNavigate = (path: string) => {
-    navigate(path, {
-      replace: location.pathname !== "/home",
-      state: { from: "app-navigation" },
-    });
-  };
-
-  return appNavigate;
-};
+import { Navigate, Outlet, useLocation } from "react-router-dom";
 
 const NoDirectAccessRoutes: React.FC = () => {
   const location = useLocation();

frontend/src/components/UseAppNavigate/index.tsx

@@ -0,0 +1,16 @@
+import { useNavigate } from "react-router-dom";
+
+export const useAppNavigate = () => {
+  const navigate = useNavigate();
+
+  const appNavigate = (path: string) => {
+    navigate(path, {
+      replace: location.pathname !== "/home",
+      state: { from: "app-navigation" },
+    });
+  };
+
+  return appNavigate;
+};
+
+export default useAppNavigate;

frontend/src/contexts/MatchContext.tsx

@@ -13,7 +13,7 @@ import {
 } from "../utils/constants";
 import { useAuth } from "./AuthContext";
 import { toast } from "react-toastify";
-import { useAppNavigate } from "../components/NoDirectAccessRoutes";
+import useAppNavigate from "../components/UseAppNavigate";
 
 type MatchUser = {
   id: string;
@@ -98,7 +98,8 @@ const MatchProvider: React.FC<{ children?: React.ReactNode }> = (props) => {
     throw new Error(USE_AUTH_ERROR_MESSAGE);
   }
   const { user } = auth;
-  const [matchUser, _setMatchUser] = useState<MatchUser | null>(
+
+  const [matchUser] = useState<MatchUser | null>(
     user
       ? {
           id: user.id,
@@ -136,6 +137,7 @@ const MatchProvider: React.FC<{ children?: React.ReactNode }> = (props) => {
       closeSocketConnection();
       window.removeEventListener("beforeunload", () => closeSocketConnection());
     };
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [matchUser?.id, location.pathname]);
 
   const resetMatchStates = () => {
@@ -220,7 +222,11 @@ const MatchProvider: React.FC<{ children?: React.ReactNode }> = (props) => {
   const initMatchRequestListeners = () => {
     matchSocket.on(MatchEvents.MATCH_FOUND, ({ matchId, user1, user2 }) => {
       setMatchId(matchId);
-      matchUser?.id === user1.id ? setPartner(user2) : setPartner(user1);
+      if (matchUser?.id === user1.id) {
+        setPartner(user2);
+      } else {
+        setPartner(user1);
+      }
       setMatchPending(true);
       appNavigate(MatchPaths.MATCHED);
     });
@@ -237,7 +243,11 @@ const MatchProvider: React.FC<{ children?: React.ReactNode }> = (props) => {
   const initMatchingListeners = () => {
     matchSocket.on(MatchEvents.MATCH_FOUND, ({ matchId, user1, user2 }) => {
       setMatchId(matchId);
-      matchUser?.id === user1.id ? setPartner(user2) : setPartner(user1);
+      if (matchUser?.id === user1.id) {
+        setPartner(user2);
+      } else {
+        setPartner(user1);
+      }
       setMatchPending(true);
       appNavigate(MatchPaths.MATCHED);
     });
@@ -256,7 +266,11 @@ const MatchProvider: React.FC<{ children?: React.ReactNode }> = (props) => {
 
     matchSocket.on(MatchEvents.MATCH_FOUND, ({ matchId, user1, user2 }) => {
       setMatchId(matchId);
-      matchUser?.id === user1.id ? setPartner(user2) : setPartner(user1);
+      if (matchUser?.id === user1.id) {
+        setPartner(user2);
+      } else {
+        setPartner(user1);
+      }
       setMatchPending(true);
       appNavigate(MatchPaths.MATCHED);
     });

frontend/src/pages/CollabSandbox/index.tsx

@@ -16,6 +16,7 @@ const CollabSandbox: React.FC = () => {
 
   useEffect(() => {
     verifyMatchStatus();
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   if (loading) {

frontend/src/pages/Matched/index.tsx

@@ -55,11 +55,14 @@ const Matched: React.FC = () => {
 
   useEffect(() => {
     if (timeLeft <= 0) {
-      accepted
-        ? toast.error(MATCH_UNSUCCESSFUL_MESSAGE)
-        : toast.error(MATCH_OFFER_TIMEOUT_MESSAGE);
+      if (accepted) {
+        toast.error(MATCH_UNSUCCESSFUL_MESSAGE);
+      } else {
+        toast.error(MATCH_OFFER_TIMEOUT_MESSAGE);
+      }
       matchOfferTimeout();
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [timeLeft]);
 
   if (!matchUser || !partner) {

frontend/src/pages/Matching/index.tsx

@@ -35,12 +35,14 @@ const Matching: React.FC = () => {
     });
 
     return () => clearInterval(timer);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   useEffect(() => {
     if (timeLeft <= 0) {
       matchingTimeout();
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [timeLeft]);
 
   if (!matchCriteria) {