Skip to content

Commit 98b5bc7

Browse files
committed
Fix more bugs with collaboration both fe and be
1 parent 716f26c commit 98b5bc7

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

backend/gateway-service/src/modules/collaboration/collaborationws.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export class CollaborationGateway implements OnGatewayDisconnect {
105105
this.server.to(sessionId).emit(SESSION_JOINED, {
106106
userId, // the user who recently joined
107107
sessionId,
108-
messages, // chat messages
108+
sessionMessages: messages, // chat messages
109109
language: existingLanguage || 'python3', // default language
110110
sessionUserProfiles, // returns the all session member profiles
111111
});

frontend/src/app/collaboration/_components/Editor/CollaborativeEditor/CollaborativeEditorTab.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useSessionContext } from "@/contexts/SessionContext";
55
export default function CollaborativeEditorTab() {
66
const {sessionId, userProfile} = useSessionContext();
77

8-
const socketUrl = process.env.NEXT_PUBLIC_Y_WEBSOCKET_URL || "ws://localhost:4001";
8+
const socketUrl = process.env.PUBLIC_Y_WEBSOCKET_URL || "ws://localhost:4001";
99

1010
if (!userProfile) {
1111
return <div>Loading user profile...</div>;

frontend/src/contexts/SessionContext.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,23 +179,25 @@ export const SessionProvider: React.FC<SessionProviderProps> = ({
179179
({
180180
userId,
181181
language,
182+
sessionMessages,
182183
sessionUserProfiles,
183184
}: {
184185
userId: string;
185186
language: string;
186-
messages: ChatMessages;
187+
sessionMessages: ChatMessages;
187188
sessionUserProfiles: SessionUserProfiles;
188189
}) => {
189190
console.log("sessionJoined occured");
190191
try {
191192
if (userProfile.id === userId) {
192193
setConnectionStatus("connected");
193194
const currentMessages = ChatMessagesSchema.parse(
194-
messages.map((message: ChatMessage) => ({
195+
sessionMessages.map((message: ChatMessage) => ({
195196
...message,
196197
status: ChatMessageStatusEnum.enum.sent,
197198
}))
198199
);
200+
199201
setMessages([...currentMessages]);
200202
}
201203

@@ -207,11 +209,12 @@ export const SessionProvider: React.FC<SessionProviderProps> = ({
207209
console.log(e);
208210
}
209211
},
210-
[messages, userProfile.id]
212+
[userProfile.id]
211213
);
212214

213215
const onChatReceiveMessage = useCallback(
214216
(newMessage: ChatMessage) => {
217+
console.log("chatReceiveMessage occured");
215218
try {
216219
newMessage["status"] = ChatMessageStatusEnum.enum.sent;
217220
const messageParsed = ChatMessageSchema.parse(newMessage);
@@ -375,7 +378,7 @@ export const SessionProvider: React.FC<SessionProviderProps> = ({
375378
setConnectionStatus("failed");
376379
}
377380

378-
if (event === "chatReceiveMessage") {
381+
if (event === "chatSendMessage") {
379382
setMessages((prev) =>
380383
prev.map((message) => {
381384
if (message.id !== data?.id) return message;

0 commit comments

Comments
 (0)