Skip to content

Commit 76de429

Browse files
Cleaned up dashboard title and summaries (#45)
# *Cleaned up dashboard title and summaries* ## ♻️ Current situation & Problem *Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.* ## ⚙️ Release Notes *Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.* *Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.* - Cleaned up visualizations dashboard title - Made data summaries more readable ## 📚 Documentation *Please ensure that you properly document any additions in conformance to [Spezi Documentation Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).* *You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.* ## ✅ Testing *Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.* *This section describes important information about the tests and why some elements might not be testable.* ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md). Co-authored-by: Merve Cerit <[email protected]>
1 parent f541d41 commit 76de429

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

NeutroFeverGuard/HKVisualization.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ struct HKVisualization: View {
9393

9494
return NavigationStack {
9595
vizList
96-
.navigationTitle("HKVIZ_NAVIGATION_TITLE")
96+
.navigationTitle("Dashboard")
9797
.onAppear {
9898
// Ensure that data up-to-date when the view is activated.
9999
self.readAllHKData(ensureUpdate: true)

NeutroFeverGuard/HKVisualizationItem.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,16 @@ struct HKVisualizationItem: View {
4545
// Helper text to show data when clicked.
4646
if let elm = selectedElement, elm.sumValue == 0 {
4747
let details = (
48-
String(localized: "HKVIZ_SUMMARY: ", locale: locale) +
48+
String(localized: "Summary: ", locale: locale) +
4949
String(elm.date.formatted(.dateTime.year().month().day())) +
5050
":\n" +
51-
String(localized: "HKVIZ_AVERAGE_STRING: ", locale: locale) +
51+
String(localized: "Average: ", locale: locale) +
5252
String(round(elm.avgValue * 10) / 10) +
5353
", " +
54-
String(localized: "HKVIZ_MAX_STRING: ", locale: locale) +
54+
String(localized: "Max Value: ", locale: locale) +
5555
String(Int(round(elm.maxValue))) +
5656
", " +
57-
String(localized: "HKVIZ_MIN_STRING: ", locale: locale) +
57+
String(localized: "Min Value: ", locale: locale) +
5858
String(Int(round(elm.minValue)))
5959
)
6060
Text(details)

NeutroFeverGuard/HomeView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ struct HomeView: View {
3131
var body: some View {
3232
TabView(selection: $selectedTab) {
3333
// Dashboard tab (HKVisualization)
34-
Tab("Dashboard", systemImage: "plus.app.fill", value: .dashboard) {
34+
Tab("Dashboard", systemImage: "heart.circle", value: .dashboard) {
3535
HKVisualization(presentingAccount: $presentingAccount)
3636
}
3737
.customizationID("home.visualization")

0 commit comments

Comments
 (0)