removed java warnings

heychalice · heychalice · commit a2aef3e76929 · 2022-12-04T23:26:30.000-05:00
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/src/main/java/com/backend/controller/AccountController.java b/src/main/java/com/backend/controller/AccountController.java
@@ -14,6 +14,7 @@ public class AccountController {
      * Spring Boot Dependency Injection of the accountSystemFacade
      * @param accountSystemFacade the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public AccountController(AccountSystemFacade accountSystemFacade) {
         this.accountSystemFacade = accountSystemFacade;
diff --git a/src/main/java/com/backend/controller/FeedController.java b/src/main/java/com/backend/controller/FeedController.java
@@ -15,6 +15,7 @@ public class FeedController {
      * Spring Boot Dependency Injection of the accountSystemFacade
      * @param feedSystemFacade the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public FeedController(FeedSystemFacade feedSystemFacade) {
         this.feedSystemFacade = feedSystemFacade;
diff --git a/src/main/java/com/backend/controller/FriendController.java b/src/main/java/com/backend/controller/FriendController.java
@@ -11,6 +11,7 @@ public class FriendController {
 
     private final FriendSystemFacade friendSystemFacade;
 
+    @SuppressWarnings("unused")
     @Autowired
     public FriendController(FriendSystemFacade friendSystemFacade) {
         this.friendSystemFacade = friendSystemFacade;
diff --git a/src/main/java/com/backend/controller/InvitationController.java b/src/main/java/com/backend/controller/InvitationController.java
@@ -10,6 +10,7 @@ public class InvitationController {
 
     private final FriendSystemFacade friendSystemFacade;
 
+    @SuppressWarnings("unused")
     @Autowired
     public InvitationController(FriendSystemFacade friendSystemFacade) {
         this.friendSystemFacade = friendSystemFacade;
diff --git a/src/main/java/com/backend/controller/PetController.java b/src/main/java/com/backend/controller/PetController.java
@@ -15,6 +15,7 @@ public class PetController {
 
     private final PetSystemFacade petSystemFacade;
 
+    @SuppressWarnings("unused")
     @Autowired
     public PetController(PetSystemFacade petSystemFacade){
         this.petSystemFacade = petSystemFacade;
diff --git a/src/main/java/com/backend/controller/RootController.java b/src/main/java/com/backend/controller/RootController.java
diff --git a/src/main/java/com/backend/controller/ShopController.java b/src/main/java/com/backend/controller/ShopController.java
@@ -15,6 +15,7 @@ public class ShopController {
     private final PetSystemFacade petSystemFacade;
 
     @Autowired
+    @SuppressWarnings("unused")
     public ShopController(PetSystemFacade petSystemFacade){
         this.petSystemFacade = petSystemFacade;
     }
diff --git a/src/main/java/com/backend/controller/TaskActiveController.java b/src/main/java/com/backend/controller/TaskActiveController.java
@@ -17,6 +17,7 @@ public class TaskActiveController {
      * Spring Boot dependency injection
      * @param taskSystemFacade of type TaskSystemFacade, establishes connection to the task system facade
      */
+    @SuppressWarnings("unused")
     public TaskActiveController(TaskSystemFacade taskSystemFacade){
         this.taskSystemFacade = taskSystemFacade;
     }
diff --git a/src/main/java/com/backend/controller/TaskCompletionController.java b/src/main/java/com/backend/controller/TaskCompletionController.java
@@ -16,6 +16,7 @@ public class TaskCompletionController {
      * Spring Boot dependency injection
      * @param taskSystemFacade of type TaskSystemFacade, establishes connection to the task system facade
      */
+    @SuppressWarnings("unused")
     public TaskCompletionController(TaskSystemFacade taskSystemFacade){
         this.taskSystemFacade = taskSystemFacade;
     }
diff --git a/src/main/java/com/backend/entities/FeedItem.java b/src/main/java/com/backend/entities/FeedItem.java
@@ -19,6 +19,7 @@ public FeedItem(ProtectedAccount account, TaskCompletionRecord record, Pet pet){
      * Get the ProtectedAccount information associated with this feedItem
      * @return the ProtectedAccount for this instance
      */
+    @SuppressWarnings("unused")
     public ProtectedAccount getAccount() {
         return this.account;
     }
@@ -27,6 +28,7 @@ public ProtectedAccount getAccount() {
      * Get the Pet information associated with this feedItem
      * @return the Pet for this instance
      */
+    @SuppressWarnings("unused")
     public Pet getPet() {
         return this.pet;
     }
diff --git a/src/main/java/com/backend/entities/Friend.java b/src/main/java/com/backend/entities/Friend.java
@@ -16,7 +16,7 @@ public class Friend {
     @Transient
     private final AccountID accountIDObject;
     @Id
-    private String accountID;
+    private final String accountID;
 
     private final ArrayList<String> friends;
 
diff --git a/src/main/java/com/backend/entities/Invitation.java b/src/main/java/com/backend/entities/Invitation.java
@@ -24,6 +24,7 @@ public class Invitation {
     private final AccountID receiverIDObject;
 
     @Id
+    @SuppressWarnings("unused")
     private final String ID;
 
     private final String senderID;
diff --git a/src/main/java/com/backend/entities/Pet.java b/src/main/java/com/backend/entities/Pet.java
@@ -14,7 +14,9 @@
  */
 @Document(collection = "PetsCollection")
 public class Pet {
+
     @Transient
+    @SuppressWarnings({"FieldCanBeLocal", "unused"})
     private final AccountID accountID;
     @Id
     @JsonIgnore
diff --git a/src/main/java/com/backend/entities/ShopItem.java b/src/main/java/com/backend/entities/ShopItem.java
@@ -15,6 +15,7 @@ public class ShopItem {
     @Transient
     private final ItemID itemID;
     @Id
+    @SuppressWarnings({"FieldCanBeLocal", "unused"})
     private final String ID;
     private final Double cost;
     private final String name;
diff --git a/src/main/java/com/backend/entities/TaskCompletionRecord.java b/src/main/java/com/backend/entities/TaskCompletionRecord.java
@@ -18,6 +18,7 @@ public class TaskCompletionRecord {
     //instance variables
     @Id
     @JsonIgnore
+    @SuppressWarnings("unused")
     private String ID;
     @Transient
     @JsonIgnore
diff --git a/src/main/java/com/backend/entities/users/Account.java b/src/main/java/com/backend/entities/users/Account.java
@@ -18,6 +18,8 @@ public class Account extends ProtectedAccount{
     // Instance Variables
     @Transient
     private final AccountID accountIDObject;
+
+    @SuppressWarnings("unused")
     @Id
     private String accountID;
     @Transient
diff --git a/src/main/java/com/backend/usecases/facades/AccountSystemFacade.java b/src/main/java/com/backend/usecases/facades/AccountSystemFacade.java
@@ -40,6 +40,7 @@ public class AccountSystemFacade {
      * @param healthManager      the dependency to be injected
      * @param taskManager        the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public AccountSystemFacade (AccountManager accountManager, PetManager petManager, HealthManager healthManager, TaskManager taskManager, FriendSystemFacade friendSystemFacade, IErrorHandler errorHandler) {
         this.accountManager = accountManager;
diff --git a/src/main/java/com/backend/usecases/facades/FeedSystemFacade.java b/src/main/java/com/backend/usecases/facades/FeedSystemFacade.java
@@ -35,6 +35,7 @@ public class FeedSystemFacade {
      * @param petManager     the dependency to be injected
      * @param errorHandler   the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public FeedSystemFacade(AccountManager accountManager, TaskManager taskManager, PetManager petManager, FriendsManager friendsManager, IErrorHandler errorHandler) {
         this.accountManager = accountManager;
diff --git a/src/main/java/com/backend/usecases/facades/FriendSystemFacade.java b/src/main/java/com/backend/usecases/facades/FriendSystemFacade.java
@@ -36,6 +36,7 @@ public class FriendSystemFacade {
      * @param friendsManager is FriendsManager to be injected
      * @param errorHandler is ErrorHandler to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public FriendSystemFacade(AccountManager accountManager, InvitationsManager invitationsManager, FriendsManager friendsManager, IErrorHandler errorHandler) {
         this.accountManager = accountManager;
diff --git a/src/main/java/com/backend/usecases/facades/PetSystemFacade.java b/src/main/java/com/backend/usecases/facades/PetSystemFacade.java
@@ -32,6 +32,7 @@ public class PetSystemFacade {
      * @param errorHandler the dependency to be injected
      */
     @Autowired
+    @SuppressWarnings("unused")
     public PetSystemFacade(ShopManager shopManager, AccountManager accountManager, PetManager petManager, BalanceManager balanceManager, IErrorHandler errorHandler){
         this.shopManager = shopManager;
         this.accountManager = accountManager;
diff --git a/src/main/java/com/backend/usecases/facades/TaskSystemFacade.java b/src/main/java/com/backend/usecases/facades/TaskSystemFacade.java
@@ -28,6 +28,7 @@ public class TaskSystemFacade {
     private final IErrorHandler errorHandler;
 
     @Autowired
+    @SuppressWarnings("unused")
     public TaskSystemFacade(TaskManager taskManager, AccountManager accountManager, BalanceManager balanceManager, HealthManager healthManager, IErrorHandler errorHandler) {
         this.taskManager = taskManager;
         this.accountManager = accountManager;
diff --git a/src/main/java/com/backend/usecases/managers/AccountManager.java b/src/main/java/com/backend/usecases/managers/AccountManager.java
@@ -24,6 +24,7 @@ public class AccountManager {
      * Spring Boot Dependency Injection of the Accounts Repository
      * @param accountsRepo the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public AccountManager(AccountsRepo accountsRepo) {
         this.accountsRepo = accountsRepo;
diff --git a/src/main/java/com/backend/usecases/managers/BalanceManager.java b/src/main/java/com/backend/usecases/managers/BalanceManager.java
@@ -20,6 +20,7 @@ public class BalanceManager {
      * @param petRepo the dependency to be injected
      * @param errorHandler the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public BalanceManager(PetRepo petRepo, IErrorHandler errorHandler) {
         this.petRepo = petRepo;
diff --git a/src/main/java/com/backend/usecases/managers/FriendsManager.java b/src/main/java/com/backend/usecases/managers/FriendsManager.java
@@ -26,6 +26,7 @@ public class FriendsManager {
      * @param friendsRepo repository to be injected
      * @param errorHandler the error handler to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public FriendsManager(FriendsRepo friendsRepo, IErrorHandler errorHandler) {
         this.friendsRepo = friendsRepo;
diff --git a/src/main/java/com/backend/usecases/managers/HealthManager.java b/src/main/java/com/backend/usecases/managers/HealthManager.java
@@ -25,6 +25,7 @@ public class HealthManager {
      * @param petRepo the dependency to be injected
      * @param errorHandler the dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public HealthManager(PetRepo petRepo, IErrorHandler errorHandler) {
         this.petRepo = petRepo;
diff --git a/src/main/java/com/backend/usecases/managers/InvitationsManager.java b/src/main/java/com/backend/usecases/managers/InvitationsManager.java
@@ -24,6 +24,7 @@ public class InvitationsManager {
      * @param invitationsRepo the repository dependency to be injected
      * @param errorHandler the ErrorHandler dependency to be injected
      */
+    @SuppressWarnings("unused")
     @Autowired
     public InvitationsManager(InvitationsRepo invitationsRepo, IErrorHandler errorHandler) {
         this.invitationsRepo = invitationsRepo;
diff --git a/src/main/java/com/backend/usecases/managers/PetManager.java b/src/main/java/com/backend/usecases/managers/PetManager.java
@@ -24,6 +24,7 @@ public class PetManager {
      * @param errorHandler the dependency to be injected
      */
     @Autowired
+    @SuppressWarnings("unused")
     public PetManager(PetRepo petRepo, IErrorHandler errorHandler) {
         this.petRepo = petRepo;
         this.errorHandler = errorHandler;
diff --git a/src/main/java/com/backend/usecases/managers/ShopManager.java b/src/main/java/com/backend/usecases/managers/ShopManager.java
@@ -30,6 +30,7 @@ public class ShopManager {
      * @param errorHandler the dependency to be injected
      */
     @Autowired
+    @SuppressWarnings("unused")
     public ShopManager(ShopItemRepo shopRepo, PetRepo petRepo, IErrorHandler errorHandler) {
         this.shopRepo = shopRepo;
         this.petRepo = petRepo;
diff --git a/src/main/java/com/backend/usecases/managers/TaskManager.java b/src/main/java/com/backend/usecases/managers/TaskManager.java
@@ -34,6 +34,7 @@ public class TaskManager {
      * @param completeRepo of type TaskCompletionRepo, establishes connection to the task completion repository
      */
     @Autowired
+    @SuppressWarnings("unused")
     public TaskManager(TaskRepo taskRepo, TaskActiveRepo activeRepo, TaskCompletionRepo completeRepo){
         this.taskRepo = taskRepo;
         this.activeRepo = activeRepo;
diff --git a/src/test/java/repositories/TaskCompletionRepoTest.java b/src/test/java/repositories/TaskCompletionRepoTest.java
@@ -27,17 +27,17 @@ public class TaskCompletionRepoTest {
     private final TaskActiveRepo taskActiveRepo;
     private final AccountSystemFacade accountSystemFacade;
     private final AccountManager accountManager;
+    private final TaskCompletionRepo taskCompletionRepo;
 
     @Autowired
-    public TaskCompletionRepoTest(TaskManager taskManager, TaskActiveRepo taskActiveRepo, AccountSystemFacade accountSystemFacade, AccountManager accountManager) {
+    public TaskCompletionRepoTest(TaskManager taskManager, TaskActiveRepo taskActiveRepo, AccountSystemFacade accountSystemFacade, AccountManager accountManager, TaskCompletionRepo taskCompletionRepo) {
         this.taskManager = taskManager;
         this.taskActiveRepo = taskActiveRepo;
         this.accountSystemFacade = accountSystemFacade;
         this.accountManager = accountManager;
+        this.taskCompletionRepo = taskCompletionRepo;
     }
 
-    @Autowired
-    TaskCompletionRepo completionRepo;
     private AccountID accountID;
     private SessionID sessionID;
 
@@ -67,7 +67,7 @@ public void findByAccountIDTest() {
         //actions
         taskManager.completeTask(accountID, expectedTask, expectedImage);
 
-        List<TaskCompletionRecord> records = completionRepo.findAllByAccountID(expectedAccountID);
+        List<TaskCompletionRecord> records = this.taskCompletionRepo.findAllByAccountID(expectedAccountID);
         TaskCompletionRecord record = records.get(0);
 
         //assertion message
diff --git a/src/test/java/usecases/facades/FriendSystemFacadeTest.java b/src/test/java/usecases/facades/FriendSystemFacadeTest.java
@@ -6,7 +6,6 @@
 import com.backend.entities.IDs.SessionID;
 import com.backend.entities.Invitation;
 import com.backend.entities.users.ProtectedAccount;
-import com.backend.repositories.AccountsRepo;
 import com.backend.repositories.FriendsRepo;
 import com.backend.repositories.InvitationsRepo;
 import com.backend.usecases.facades.AccountSystemFacade;

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ public class ShopController {`
`15`	`15`	`private final PetSystemFacade petSystemFacade;`
`16`	`16`
`17`	`17`	`@Autowired`
	`18`	`+ @SuppressWarnings("unused")`
`18`	`19`	`public ShopController(PetSystemFacade petSystemFacade){`
`19`	`20`	`this.petSystemFacade = petSystemFacade;`
`20`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ public class TaskActiveController {`
`17`	`17`	`* Spring Boot dependency injection`
`18`	`18`	`* @param taskSystemFacade of type TaskSystemFacade, establishes connection to the task system facade`
`19`	`19`	`*/`
	`20`	`+ @SuppressWarnings("unused")`
`20`	`21`	`public TaskActiveController(TaskSystemFacade taskSystemFacade){`
`21`	`22`	`this.taskSystemFacade = taskSystemFacade;`
`22`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ public class TaskCompletionController {`
`16`	`16`	`* Spring Boot dependency injection`
`17`	`17`	`* @param taskSystemFacade of type TaskSystemFacade, establishes connection to the task system facade`
`18`	`18`	`*/`
	`19`	`+ @SuppressWarnings("unused")`
`19`	`20`	`public TaskCompletionController(TaskSystemFacade taskSystemFacade){`
`20`	`21`	`this.taskSystemFacade = taskSystemFacade;`
`21`	`22`	`}`