Skip to content

Commit 7638f52

Browse files
committed
Fixed documentations.
1 parent 4a70ee0 commit 7638f52

File tree

8 files changed

+36
-11
lines changed

8 files changed

+36
-11
lines changed

src/main/java/create_flashcard_use_case/CreateFlashcardInteractor.java

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class CreateFlashcardInteractor implements CreateFlashcardInputBoundary {
1313
DBGateway gateway;
1414

1515
/**
16-
* Create FcCInteractor
16+
* Create CreateFlashcardInteractor
1717
* @param gateway Database gateway.
1818
* @param presenter Presenter for failure or success view.
1919
*/
@@ -23,8 +23,9 @@ public CreateFlashcardInteractor(DBGateway gateway, CreateFlashcardOutputBoundar
2323
}
2424

2525
/**
26-
* Create flashcard with given term, definition in the given flashcard set recording the date of creation.
27-
* If term or definition is empty flashcard set does not exist, returns the corresponding error.
26+
* Try to create a flashcard with the given term and definition in the given flashcard set, recording the date of creation.
27+
* If the term or definition is empty flashcard set does not exist, return the corresponding error.
28+
* If there is already a flashcard with the same term, return the response model representing the existing flashcard.
2829
* @return Success or failure view.
2930
*/
3031
@Override
@@ -39,7 +40,7 @@ else if (gateway.getFlashcardSet(requestModel.getFlashcardSetId()) == null) {
3940
}
4041
for (int flashcardId : gateway.getFlashcardSet(requestModel.getFlashcardSetId()).getFlashcardIds()){
4142
if (gateway.getFlashcard(flashcardId).getTerm().equals(term)){
42-
return presenter.prepareFailView(new CreateFlashcardResponseModel(LocalDateTime.now(), requestModel.getTerm(),
43+
return presenter.prepareDuplicateView(new CreateFlashcardResponseModel(LocalDateTime.now(), requestModel.getTerm(),
4344
gateway.getFlashcard(flashcardId).getDefinition(), flashcardId, true));
4445
}
4546
}
@@ -51,9 +52,25 @@ else if (gateway.getFlashcardSet(requestModel.getFlashcardSetId()) == null) {
5152

5253
}
5354

55+
56+
/**
57+
* Try to create a flashcard with the given term and definition in the given flashcard set,
58+
* overwrite the flashcard at flashcardId.
59+
* If the term or definition is empty flashcard set does not exist, return the corresponding error.
60+
* If there is already a flashcard with the same term, return the response model representing the existing flashcard.
61+
* @param requestModel request model
62+
* @param flashcardId flashcardId for the method to overwrite
63+
* @return success or failure view
64+
*/
5465
public CreateFlashcardResponseModel create(CreateFlashcardRequestModel requestModel, int flashcardId){
5566
String term = requestModel.getTerm().replace("\n", " ").trim();
5667
String definition = requestModel.getDefinition().replace("\n", " ").trim();
68+
if(term.isEmpty() || definition.isEmpty()){
69+
return presenter.prepareFailView("Term or definition is empty.");
70+
}
71+
else if (gateway.getFlashcardSet(requestModel.getFlashcardSetId()) == null) {
72+
return presenter.prepareFailView("Flashcard set does not exist.");
73+
}
5774
LocalDateTime creationDate = LocalDateTime.now();
5875
gateway.editFlashcard(new FlashcardDsRequestModel(term, definition, creationDate, flashcardId,
5976
requestModel.getFlashcardSetId()));

src/main/java/create_flashcard_use_case/CreateFlashcardOutputBoundary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
public interface CreateFlashcardOutputBoundary {
88
CreateFlashcardResponseModel prepareSuccessView(CreateFlashcardResponseModel responseModel);
99
CreateFlashcardResponseModel prepareFailView(String error);
10-
CreateFlashcardResponseModel prepareFailView(CreateFlashcardResponseModel responseModel);
10+
CreateFlashcardResponseModel prepareDuplicateView(CreateFlashcardResponseModel responseModel);
1111
}

src/main/java/create_flashcard_use_case/CreateFlashcardRequestModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class CreateFlashcardRequestModel {
1111
private String term, definition;
1212

1313
/**
14-
* Create FcCRequestModel
14+
* Create CreateFlashcardRequestModel
1515
* @param flashcardSetId id of flashcard set which new flashcard will be added to
1616
* @param term term of the flashcard
1717
* @param definition definition of the flashcard

src/main/java/create_flashcard_use_case/CreateFlashcardResponseModel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ public class CreateFlashcardResponseModel {
1313
private final Boolean existsDuplicate;
1414

1515
/**
16-
*Creating CreateFlashcardResponseModel for flashcard creation
16+
*Create CreateFlashcardResponseModel for flashcard creation
1717
* @param creationDate date of creation
1818
* @param term term of the flashcard
1919
* @param definition definition of the flashcard
2020
* @param flashcardId flashcard id of the flashcard
21-
* @param existsDuplicate if there is duplicate flashcard currently
21+
* @param existsDuplicate if there is a duplicate flashcard currently
2222
*/
2323
public CreateFlashcardResponseModel(LocalDateTime creationDate, String term, String definition, int flashcardId, Boolean existsDuplicate) {
2424
this.creationDate = creationDate;

src/main/java/delete_flashcard_use_case/DeleteFlashcardInteractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class DeleteFlashcardInteractor implements DeleteFlashcardInputBoundary {
1414
DBGateway gateway;
1515

1616
/**
17-
* Create FcRInteractor.
17+
* Create DeleteFlashcardInteractor.
1818
* @param gateway Database gateway.
1919
* @param presenter presenter that prepares success or failure view.
2020
*/

src/main/java/interface_adapters/controllers/CreateFlashcardController.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@ public CreateFlashcardController(CreateFlashcardInputBoundary inputBoundary, int
2424
this.flashcardSetId = flashcardSetId;
2525
}
2626

27+
/**
28+
* If flashcardId is -1, try to create a new flashcard.
29+
* If flashcardId is not -1, try to create a new flashcard at the given flashcard id.
30+
* @param term term of the flashcard
31+
* @param definition definition of the flashcard
32+
* @param flashcardId flashcard id to write to, -1 is a placeholder meaning no given flashcard id.
33+
* @return CreateFlashcardResponseModel
34+
*/
2735
public CreateFlashcardResponseModel create(String term, String definition, int flashcardId){
2836
if (flashcardId == -1){
2937
return inputBoundary.create(new CreateFlashcardRequestModel(flashcardSetId, term, definition));

src/main/java/interface_adapters/controllers/DeleteFlashcardController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class DeleteFlashcardController {
1313
DeleteFlashcardInputBoundary inputBoundary;
1414

1515
/**
16-
* Create FcRController.
16+
* Create DeleteFlashcardController.
1717
* @param inputBoundary interactor for flashcard remover.
1818
*/
1919
public DeleteFlashcardController(DeleteFlashcardInputBoundary inputBoundary){

src/main/java/interface_adapters/presenters/CreateFlashcardPresenter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public CreateFlashcardResponseModel prepareFailView(String error) {
3636
* @return the responseModel
3737
*/
3838
@Override
39-
public CreateFlashcardResponseModel prepareFailView(CreateFlashcardResponseModel responseModel) {
39+
public CreateFlashcardResponseModel prepareDuplicateView(CreateFlashcardResponseModel responseModel) {
4040
return responseModel;
4141
}
4242
}

0 commit comments

Comments
 (0)