Updated to use enum ListType

Author: kchprog

src/main/java/org/hydev/mcpm/client/commands/controllers/ListController.java

@@ -2,6 +2,7 @@
 
 import org.hydev.mcpm.client.list.ListAllBoundary;
 import org.hydev.mcpm.client.updater.CheckForUpdatesBoundary;
+import org.hydev.mcpm.client.list.ListType;
 
 import java.util.List;
 import java.util.function.Consumer;
@@ -34,7 +35,27 @@ public ListController(ListAllBoundary listAllBoundary, CheckForUpdatesBoundary c
      * @param log       Logger
      */
     public void listAll(String parameter, Consumer<String> log) {
-        var list = listAllBoundary.listAll(parameter, checkForUpdatesBoundary);
+
+        ListType listType;
+        switch (parameter) {
+            case "all":
+                listType = ListType.ALL;
+                break;
+            case "manual":
+                listType = ListType.MANUAL;
+                break;
+            case "automatic":
+                listType = ListType.AUTOMATIC;
+                break;
+            case "outdated":
+                listType = ListType.OUTDATED;
+                break;
+            default:
+                log.accept("Invalid parameter. Please use 'all', 'manual', 'automatic', or 'outdated'.");
+                return;
+        }
+
+        var list = listAllBoundary.listAll(listType, checkForUpdatesBoundary);
 
         // Tabulate result
         var table = tabulate(

src/main/java/org/hydev/mcpm/client/list/ListAllBoundary.java

@@ -22,5 +22,6 @@ public interface ListAllBoundary {
      *                  a request to list all manually installed plugins that are
      *                  outdated.
      */
-    List<PluginYml> listAll(String parameter, CheckForUpdatesBoundary checkForUpdatesBoundary);
+
+    List<PluginYml> listAll(ListType parameter, CheckForUpdatesBoundary checkForUpdatesBoundary);
 }

src/main/java/org/hydev/mcpm/client/list/ListAllInteractor.java

@@ -25,21 +25,21 @@ public record ListAllInteractor(SuperPluginTracker pluginTracker) implements Lis
      *                  a request to list all manually installed plugins that are
      *                  outdated.
      */
-    public List<PluginYml> listAll(String parameter, CheckForUpdatesBoundary checkForUpdatesBoundary) {
+    public List<PluginYml> listAll(ListType parameter, CheckForUpdatesBoundary checkForUpdatesBoundary) {
         var installed = pluginTracker.listInstalled();
         switch (parameter) {
-            case "all":
+            case ALL:
                 return installed;
 
-            case "manual":
+            case MANUAL:
                 var local = pluginTracker.listManuallyInstalled();
                 return installed.stream().filter(it -> local.contains(it.name())).toList();
 
-            case "automatic":
+            case AUTOMATIC:
                 var manual = pluginTracker.listManuallyInstalled();
                 return installed.stream().filter(it -> !manual.contains(it.name())).toList();
 
-            case "outdated":
+            case OUTDATED:
                 ListUpdateableBoundary listUpdateableBoundary = new ListUpdateableHelper();
                 var outdated = listUpdateableBoundary.listUpdateable(pluginTracker, checkForUpdatesBoundary);
                 return installed.stream().filter(it -> outdated.contains(it.name())).toList();

src/main/java/org/hydev/mcpm/client/list/ListType.java

@@ -0,0 +1,8 @@
+package org.hydev.mcpm.client.list;
+
+/**
+ * Enum representing different possible inputs
+ */
+public enum ListType {
+    ALL, MANUAL, AUTOMATIC, OUTDATED
+}

src/main/java/org/hydev/mcpm/client/list/ListUpdateableHelper.java

@@ -22,7 +22,7 @@
 public class ListUpdateableHelper implements ListUpdateableBoundary {
 
     /**
-     * Returns a list of plugins that are outdated.
+     * Returns a list of plugins names that belong to outdated plugins
      *
      * @param localPluginTracker      The plugin tracker in question
      * @param checkForUpdatesBoundary The boundary to check for updates