Use LocalJarBoundary in uninstall use case

Author: aanushkasharma

src/main/java/org/hydev/mcpm/client/uninstall/UninstallBoundary.java

@@ -9,7 +9,7 @@ public interface UninstallBoundary {
     /**
      * Uninstalls plugin based on its given name
      *
-     * @param name given name of plugin
+     * @param input Uninstall input
      */
-    void uninstall(String name) throws PluginNotFoundException;
+    UninstallResult uninstall(UninstallInput input) throws PluginNotFoundException;
 }

src/main/java/org/hydev/mcpm/client/uninstall/UninstallInput.java

@@ -1,20 +1,13 @@
 package org.hydev.mcpm.client.uninstall;
 
-import org.hydev.mcpm.client.database.inputs.SearchPackagesType;
-import org.hydev.mcpm.client.injector.PluginLoader;
-
 /**
  * Uninstall Plugin input
  *
  * @param name Plugin name
- * @param ulb PluginLoader object
- * @param spType SearchPackagesType
  * @param recursive remove dependencies or not
  */
 public  record UninstallInput(
     String name,
-    PluginLoader ulb,
-    SearchPackagesType spType,
     boolean recursive
 ) { }
 

src/main/java/org/hydev/mcpm/client/uninstall/UninstallResult.java

@@ -0,0 +1,15 @@
+package org.hydev.mcpm.client.uninstall;
+
+/**
+ * Result for uninstalling
+ *
+ * @author Anushka (https://github.com/aanushkasharma)
+ * @since 2022-11-27
+ */
+public record UninstallResult(State state)
+{
+    public enum State {
+        FAILED_TO_DELETE,
+        SUCCESS
+    }
+}

src/main/java/org/hydev/mcpm/client/uninstall/Uninstaller.java

@@ -1,10 +1,14 @@
 package org.hydev.mcpm.client.uninstall;
 
-import org.hydev.mcpm.client.injector.PluginLoader;
+import org.hydev.mcpm.client.database.PluginTracker;
+import org.hydev.mcpm.client.injector.LocalJarBoundary;
 import org.hydev.mcpm.client.injector.PluginNotFoundException;
+import org.hydev.mcpm.client.injector.UnloadBoundary;
 
 import java.io.File;
-import java.util.Arrays;
+
+import static org.hydev.mcpm.client.uninstall.UninstallResult.State.FAILED_TO_DELETE;
+import static org.hydev.mcpm.client.uninstall.UninstallResult.State.SUCCESS;
 
 
 /**
@@ -13,33 +17,57 @@
  * @author Anushka (https://github.com/aanushkasharma)
  */
 public class Uninstaller implements UninstallBoundary {
+    private final PluginTracker tracker;
+    private final UnloadBoundary unloader;
+    private final LocalJarBoundary jarFinder;
+
+    public Uninstaller(PluginTracker tracker, UnloadBoundary unloader, LocalJarBoundary jarFinder) {
+        this.tracker = tracker;
+        this.unloader = unloader;
+        this.jarFinder = jarFinder;
+    }
+
     @Override
-    public void uninstall(String name) throws PluginNotFoundException {
-        PluginLoader pil = new PluginLoader();
-        pil.unloadPlugin(name);
-
-        // Find plugin file
-        // could be useful for removing dependencies (?)
-        var pluginFolder = new File("plugins");
-        var files = pluginFolder.listFiles();
-        if (files == null) {
-            files = new File[]{};
+    public UninstallResult uninstall(UninstallInput input) throws PluginNotFoundException {
+        // 1. Unload plugin
+        // This will throw PluginNotFoundException if the plugin isn't loaded. If it is loaded,
+        // this will return the jar of the currently loaded plugin, which is the most precise.
+        // Since people may still uninstall a plugin when it's not loaded, we ignore the not
+        // found error here.
+        File jar = null;
+        if (unloader != null) {
+            try {
+                jar = unloader.unloadPlugin(input.name());
+            }
+            catch (PluginNotFoundException ignored) { }
         }
 
-        var plugins = Arrays.stream(files)
-                .filter(plugin -> plugin.getName().endsWith(name + ".jar")).toList();
+        // 2. If it isn't loaded, find the plugin jar file in local file system
+        if (jar == null) {
+            // This will throw PluginNotFoundException when a plugin of the name in the file system
+            // could not be found.
+            jar = jarFinder.findJar(input.name());
+        }
 
-        if (plugins.size() == 0) {
-            throw new PluginNotFoundException("Plugin " + name + " not found.");
+        // 3. Delete plugin jar
+        if (!jar.delete()) {
+            return new UninstallResult(FAILED_TO_DELETE);
         }
 
-        File file = new File(plugins.get(0).toString());
+        // 4. Remove manually installed flag from the tracker
+        tracker.removeEntry(input.name());
 
-        // Delete plugin
-        if (file.delete()) {
-            System.out.println("File deleted successfully");
-        } else {
-            System.out.println("Failed to delete the file");
+        // 5. Remove orphan dependencies
+        if (input.recursive()) {
+            var orphans = tracker.listOrphanPlugins(false);
+            for (var orphan : orphans) {
+                try {
+                    uninstall(new UninstallInput(orphan, true));
+                }
+                catch (PluginNotFoundException ignored) { }
+            }
         }
+
+        return new UninstallResult(SUCCESS);
     }
 }