Skip to content

Commit a8db35b

Browse files
committed
cleaned up code
1 parent da7cd48 commit a8db35b

File tree

1 file changed

+13
-22
lines changed

1 file changed

+13
-22
lines changed

src/main/java/org/hydev/mcpm/client/commands/controllers/ListController.java

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,14 @@
22

33
import org.hydev.mcpm.client.display.presenters.ListPresenter;
44
import org.hydev.mcpm.client.list.ListAllBoundary;
5-
import org.hydev.mcpm.client.models.PluginYml;
5+
66
import org.hydev.mcpm.client.updater.CheckForUpdatesBoundary;
77
import org.hydev.mcpm.client.list.ListType;
88
import org.hydev.mcpm.client.list.ListResult;
9-
import org.hydev.mcpm.client.commands.presenters.ListResultPresenter;
109

11-
import java.util.List;
12-
import java.util.function.Consumer;
1310

14-
import static org.hydev.mcpm.client.display.presenters.Table.tabulate;
11+
12+
import java.util.function.Consumer;
1513

1614
/**
1715
* Controller class for the ListAll use case.
@@ -43,35 +41,28 @@ public void listAll(String parameter, Consumer<String> log) {
4341
ListPresenter listPresenter = new ListPresenter(log);
4442
ListType listType;
4543
switch (parameter.toLowerCase()) {
46-
case "all":
47-
listType = ListType.ALL;
48-
break;
49-
case "manual":
50-
listType = ListType.MANUAL;
51-
break;
52-
case "automatic":
53-
listType = ListType.AUTOMATIC;
54-
break;
55-
case "outdated":
56-
listType = ListType.OUTDATED;
57-
break;
58-
default:
44+
case "all" -> listType = ListType.ALL;
45+
case "manual" -> listType = ListType.MANUAL;
46+
case "automatic" -> listType = ListType.AUTOMATIC;
47+
case "outdated" -> listType = ListType.OUTDATED;
48+
default -> {
5949
ListResult queryResult = new ListResult(null, ListResult.Type.SEARCH_INVALID_INPUT);
6050
listPresenter.displayResult(queryResult);
6151
return;
52+
}
6253
}
6354

6455
try {
6556
var list = listAllBoundary.listAll(listType);
6657

6758
// if list is empty
59+
ListResult queryResult;
6860
if (list.isEmpty()) {
69-
ListResult queryResult = new ListResult(list, ListResult.Type.SUCCESS_RETRIEVING_BUT_NO_MATCHES);
70-
listPresenter.displayResult(queryResult);
61+
queryResult = new ListResult(list, ListResult.Type.SUCCESS_RETRIEVING_BUT_NO_MATCHES);
7162
} else {
72-
ListResult queryResult = new ListResult(list, ListResult.Type.SUCCESS_RETRIEVING_LOCAL_AND_UPDATABLE);
73-
listPresenter.displayResult(queryResult);
63+
queryResult = new ListResult(list, ListResult.Type.SUCCESS_RETRIEVING_LOCAL_AND_UPDATABLE);
7464
}
65+
listPresenter.displayResult(queryResult);
7566
} catch (Exception e) {
7667
ListResult queryResult = new ListResult(null, ListResult.Type.SEARCH_FAILED_TO_FETCH_INSTALLED);
7768
listPresenter.displayResult(queryResult);

0 commit comments

Comments
 (0)