[O] PluginLoader: Make loadPlugin return success status

Author: hykilpikonna

src/main/java/org/hydev/mcpm/client/injector/LoadBoundary.java

@@ -14,13 +14,16 @@ public interface LoadBoundary
      * Dynamically load a local plugin through JVM reflections and classloader hacks
      *
      * @param name Loaded plugin name
+     * @return True if success, false if failed
+     * @throws PluginNotFoundException Plugin of the name is not found in the plugins directory
      */
-    public void loadPlugin(String name) throws PluginNotFoundException;
+    public boolean loadPlugin(String name) throws PluginNotFoundException;
 
     /**
      * Dynamically load a local plugin through JVM reflections and classloader hacks
      *
      * @param jar Local jar file path
+     * @return True if success, false if failed
      */
-    public void loadPlugin(File jar);
+    public boolean loadPlugin(File jar);
 }

src/main/java/org/hydev/mcpm/client/injector/PluginLoader.java

@@ -29,7 +29,7 @@
 public class PluginLoader implements LoadBoundary, UnloadBoundary, ReloadBoundary
 {
     @Override
-    public void loadPlugin(String name) throws PluginNotFoundException
+    public boolean loadPlugin(String name) throws PluginNotFoundException
     {
         // 1. Find plugin file by name
         var nf = new PluginNotFoundException(name);
@@ -45,28 +45,30 @@ public void loadPlugin(String name) throws PluginNotFoundException
                 catch (IOException ignored) { return false; }
             }).findFirst().orElseThrow(() -> nf);
 
-        loadPlugin(file);
+        return loadPlugin(file);
     }
 
     @Override
-    public void loadPlugin(File jar)
+    public boolean loadPlugin(File jar)
     {
         // 2. Load plugin
         var pm = Bukkit.getPluginManager();
         try
         {
             var plugin = pm.loadPlugin(jar);
-            assert plugin != null;
+            if (plugin == null) return false;
 
             // 3. Call onLoad()
             plugin.onLoad();
             pm.enablePlugin(plugin);
+            return true;
         }
         catch (InvalidPluginException | InvalidDescriptionException e)
         {
             // These are errors indicating that the plugin we're trying to load is badly formatted.
             // There are nothing we can do.
             e.printStackTrace();
+            return false;
         }
     }