Skip to content

Commit e6f5c82

Browse files
James CraigJames Craig
authored andcommitted
v520 - minor fixes to EnKF (negative states) and LatFlush (fractional area calcs)
1 parent babadb6 commit e6f5c82

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/EnKF.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ void CEnKFEnsemble::UpdateFromStateMatrix(CModel* pModel,optStruct& Options,cons
661661
{
662662
CHydroUnit *pHRU=pModel->GetHRUGroup(kk)->GetHRU(k);
663663
int iii=pModel->GetStateVarIndex(_aAssimStates[i],_aAssimLayers[i]);
664-
pHRU->SetStateVarValue(iii,_state_matrix[e][ii]); ii++;
664+
pHRU->SetStateVarValue(iii,max(_state_matrix[e][ii],0.0)); ii++;
665665
}
666666
}
667667
}

src/LatFlush.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ void CmvLatFlush::Initialize()
130130
}
131131
}
132132
for (int qq = 0; qq < nRecipients; qq++) {//once sum is known for each source, calculate fraction
133-
_aFrac[q-qq]=_aFrac[q-qq]/Asum;
133+
_aFrac[q-qq-1]=_aFrac[q-qq-1]/Asum;
134134
}
135135
}
136136
}
@@ -235,6 +235,7 @@ void CmvLatFlush::GetLateralExchange( const double * const *state_vars, //ar
235235

236236
if (_divert) {
237237
mult=pHRUs[_kFrom[q]]->GetSurfaceProps()->divert_fract;
238+
//cout<<" Lat Flush "<<q<<" kFrom: "<<_kFrom[q]<<" "<<_kTo[q] <<" iFrom: "<<_iFromLat[q]<<" "<< mult << " " << _aFrac[q] << " " << stor << endl;
238239
}
239240

240241
exchange_rates[q]=max(mult*stor,0.0)/Options.timestep*Afrom*_aFrac[q]; //[mm-m2/d]

0 commit comments

Comments
 (0)