Skip to content

Commit 166859f

Browse files
committed
Bump minimum Node version to 0.8 and add CI tests
- Removes workaround for node exit not properly flushing on 0.4 and lower - Add Travis test runs for each of the supported node version Fixes #378
1 parent 14899c9 commit 166859f

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@ language: node_js
22
node_js:
33
- "0.8"
44
- "0.10"
5+
- "0.11"
56
before_install:
67
- npm install -g grunt-cli

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
}
1212
],
1313
"engines": {
14-
"node": ">=0.2.0"
14+
"node": ">=0.8.0"
1515
},
1616
"directories": {
1717
"lib": "lib"

src/cli/node.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,7 @@ cli({
1717
},
1818

1919
quit: function(code){
20-
21-
//Workaround for https://github.com/joyent/node/issues/1669
22-
23-
if ((!process.stdout.flush || !process.stdout.flush()) && (parseFloat(process.versions.node) < 0.5)) {
24-
process.once("drain", function () {
25-
process.exit(code || 0);
26-
});
27-
} else {
28-
process.exit(code || 0);
29-
}
20+
process.exit(code || 0);
3021
},
3122

3223
isDirectory: function(name){

0 commit comments

Comments
 (0)