Ensure text-indent rule doesn't throw an error (fixes #179)

Author: Nicholas C. Zakas

src/rules/text-indent.js

@@ -27,7 +27,7 @@ CSSLint.addRule({
         //event handler for end of rules
         function endRule(event){
             if (textIndent){
-                reporter.warn("Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set text-direction for that item to ltr.", name.line, name.col, rule);
+                reporter.warn("Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set text-direction for that item to ltr.", textIndent.line, textIndent.col, rule);
             }
         }        
 
@@ -37,10 +37,10 @@ CSSLint.addRule({
         //check for use of "font-size"
         parser.addListener("property", function(event){
             var name = event.property.toString().toLowerCase(),
-                value = event.value.parts[0].value;
+                value = event.value;
 
-            if (name == "text-indent" && value < -99){
-                textIndent = true;
+            if (name == "text-indent" && value.parts[0].value < -99){
+                textIndent = event.property;
             } else if (name == "direction" && value == "ltr"){
                 textIndent = false;
             }

tests/rules/text-indent.js

@@ -27,6 +27,13 @@
         "5px text-indent should not result in a warning": function(){
             var result = CSSLint.verify(".foo{text-indent: 5px;}", {"text-indent": 1 });
             Assert.areEqual(0, result.messages.length);
+        },
+        
+        "This should cause a warning, not an error": function(){
+            var result = CSSLint.verify(".top h1 a { background: url(../images/background/logo.png) no-repeat; display: block; height: 44px; position: relative; text-indent: -9999px; width: 250px; }", { "text-indent": 1 });
+            Assert.areEqual(1, result.messages.length);
+            Assert.areEqual("warning", result.messages[0].type);
+            Assert.areEqual("Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set text-direction for that item to ltr.", result.messages[0].message);
         }
 
     }));