Skip to content

Commit 6e57d09

Browse files
committed
clone ruleset before passing it to applyEmbeddedRuleset; fixes #458
since applyEmbeddedRuleset modifies the ruleset in-place, this ensures that those modifications aren't visible to the caller
1 parent e79c5e7 commit 6e57d09

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/core/CSSLint.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @extends parserlib.util.EventTarget
66
*/
77

8-
/* global parserlib, Reporter */
8+
/* global parserlib, clone, Reporter */
99
/* exported CSSLint */
1010

1111
var CSSLint = (function(){
@@ -189,6 +189,8 @@ var CSSLint = (function(){
189189
}
190190

191191
if (embeddedRuleset.test(text)){
192+
//defensively copy so that caller's version does not get modified
193+
ruleset = clone(ruleset);
192194
ruleset = applyEmbeddedRuleset(text, ruleset);
193195
}
194196

0 commit comments

Comments
 (0)