Merge pull request #487 from XhmikosR/unused

nschonni · nschonni · commit 901566424016 · 2014-04-09T21:25:40.000-04:00
Remove unused variables.
diff --git a/.jshintrc b/.jshintrc
@@ -10,6 +10,7 @@
     "noempty": true,
     "nonbsp": true,
     "quotmark": "double",
+    "unused": true,
     "undef": true,
     "globals": {
         "CSSLint": true,
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -1,4 +1,5 @@
-/*global module:false*/
+/* jshint evil:true, node:true */
+
 module.exports = function(grunt) {
 
     // Project configuration.
@@ -221,11 +222,9 @@ module.exports = function(grunt) {
 
     //Run the YUITest suite
     grunt.registerMultiTask("yuitest", "Run the YUITests for the project", function() {
-        /*jshint evil:true, node:true*/
 
-        var start = Date.now();
         var YUITest = require("yuitest");
-        var CSSLint = require("./build/csslint-node").CSSLint;
+        var CSSLint = require("./build/csslint-node").CSSLint;  // jshint ignore:line
         var files = this.filesSrc;
         var TestRunner = YUITest.TestRunner;
         var done = this.async();
@@ -375,7 +374,7 @@ module.exports = function(grunt) {
         grunt.util.spawn({
             cmd: "git",
             args: ["tag"]
-        }, function(error, result, code) {
+        }, function(error, result) {
             //Find the latest git tag
             var tags = result.stdout.split("\n"),
                 semver = tags[0].replace("v","").split("."),
@@ -386,7 +385,7 @@ module.exports = function(grunt) {
             //A simple array sort can't be used because of the comparison of
             //the strings "0.9.9" > "0.9.10"
             for (var i = 1, len = tags.length; i < len; i++) {
-                semver = tags[i].replace("v","").split(".");
+                semver = tags[i].replace("v", "").split(".");
 
                 var currentMajor = parseInt(semver[0], 10);
                 if (currentMajor < major) {
@@ -418,7 +417,7 @@ module.exports = function(grunt) {
             grunt.util.spawn({
                 cmd: "git",
                 args: ["log", "--pretty=format:'* %s (%an)'", lastTag + "..HEAD"]
-            }, function(error, result, code) {
+            }, function(error, result) {
                 var prettyPrint =  result.stdout.split("'\n'").join("\n").replace(/\"$/, "").replace(/^\"/, "");
 
                 grunt.verbose.writeln().write(prettyPrint).writeln();
@@ -446,7 +445,7 @@ module.exports = function(grunt) {
                 cmd: "java",
                 args: ["-jar", "lib/js.jar", "lib/yuitest-rhino-cli.js", "build/csslint.js", filepath],
                 opts: {stdio: "inherit"}
-            }, function(error, result, code) {
+            }, function() {
                 progress--;
                 if (progress === 0) {
                     done();
diff --git a/src/cli/common.js b/src/cli/common.js
@@ -3,6 +3,8 @@
  * provides environment-specific functionality.
  */
 
+/* exported cli */
+
 function cli(api){
 
     var globalOptions = {
diff --git a/src/cli/node.js b/src/cli/node.js
@@ -2,8 +2,9 @@
  * CSSLint Node.js Command Line Interface
  */
 
-/*jshint node:true*/
-/*global cli*/
+/* jshint node:true */
+/* global cli */
+/* exported CSSLint */
 
 var fs      = require("fs"),
     path    = require("path"),
diff --git a/src/core/CSSLint.js b/src/core/CSSLint.js
@@ -4,7 +4,10 @@
  * @static
  * @extends parserlib.util.EventTarget
  */
-/*global parserlib, Reporter*/
+
+/* global parserlib, Reporter */
+/* exported CSSLint */
+
 var CSSLint = (function(){
 
     var rules           = [],
@@ -170,8 +173,7 @@ var CSSLint = (function(){
      */
     api.verify = function(text, ruleset){
 
-        var i       = 0,
-            len     = rules.length,
+        var i = 0,
             reporter,
             lines,
             report,
diff --git a/src/formatters/checkstyle-xml.js b/src/formatters/checkstyle-xml.js
@@ -69,7 +69,7 @@
          * @param options {Object} (UNUSED for now) specifies special handling of output
          * @return {String} output for results
          */
-        formatResults: function(results, filename, options) {
+        formatResults: function(results, filename/*, options*/) {
             var messages = results.messages,
                 output = [];
 
@@ -91,7 +91,7 @@
 
             if (messages.length > 0) {
                 output.push("<file name=\""+filename+"\">");
-                CSSLint.Util.forEach(messages, function (message, i) {
+                CSSLint.Util.forEach(messages, function (message) {
                     //ignore rollups for now
                     if (!message.rollup) {
                         output.push("<error line=\"" + message.line + "\" column=\"" + message.col + "\" severity=\"" + message.type + "\"" +
diff --git a/src/formatters/compact.js b/src/formatters/compact.js
@@ -44,7 +44,7 @@ CSSLint.addFormatter({
             return options.quiet ? "" : filename + ": Lint Free!";
         }
 
-        CSSLint.Util.forEach(messages, function(message, i) {
+        CSSLint.Util.forEach(messages, function(message) {
             if (message.rollup) {
                 output += filename + ": " + capitalize(message.type) + " - " + message.message + "\n";
             } else {
diff --git a/src/formatters/csslint-xml.js b/src/formatters/csslint-xml.js
@@ -26,7 +26,7 @@ CSSLint.addFormatter({
      * @param options {Object} (UNUSED for now) specifies special handling of output
      * @return {String} output for results
      */
-    formatResults: function(results, filename, options) {
+    formatResults: function(results, filename/*, options*/) {
         var messages = results.messages,
             output = [];
 
@@ -51,7 +51,7 @@ CSSLint.addFormatter({
 
         if (messages.length > 0) {
             output.push("<file name=\""+filename+"\">");
-            CSSLint.Util.forEach(messages, function (message, i) {
+            CSSLint.Util.forEach(messages, function (message) {
                 if (message.rollup) {
                     output.push("<issue severity=\"" + message.type + "\" reason=\"" + escapeSpecialCharacters(message.message) + "\" evidence=\"" + escapeSpecialCharacters(message.evidence) + "\"/>");
                 } else {
diff --git a/src/formatters/junit-xml.js b/src/formatters/junit-xml.js
@@ -26,7 +26,7 @@ CSSLint.addFormatter({
      * @param options {Object} (UNUSED for now) specifies special handling of output
      * @return {String} output for results
      */
-    formatResults: function(results, filename, options) {
+    formatResults: function(results, filename/*, options*/) {
 
         var messages = results.messages,
             output = [],
@@ -72,7 +72,7 @@ CSSLint.addFormatter({
 
         if (messages.length > 0) {
 
-            messages.forEach(function (message, i) {
+            messages.forEach(function (message) {
 
                 // since junit has no warning class
                 // all issues as errors
diff --git a/src/formatters/lint-xml.js b/src/formatters/lint-xml.js
@@ -26,7 +26,7 @@ CSSLint.addFormatter({
      * @param options {Object} (UNUSED for now) specifies special handling of output
      * @return {String} output for results
      */
-    formatResults: function(results, filename, options) {
+    formatResults: function(results, filename/*, options*/) {
         var messages = results.messages,
             output = [];
 
@@ -52,7 +52,7 @@ CSSLint.addFormatter({
         if (messages.length > 0) {
 
             output.push("<file name=\""+filename+"\">");
-            CSSLint.Util.forEach(messages, function (message, i) {
+            CSSLint.Util.forEach(messages, function (message) {
                 if (message.rollup) {
                     output.push("<issue severity=\"" + message.type + "\" reason=\"" + escapeSpecialCharacters(message.message) + "\" evidence=\"" + escapeSpecialCharacters(message.evidence) + "\"/>");
                 } else {
diff --git a/src/rules/bulletproof-font-face.js b/src/rules/bulletproof-font-face.js
@@ -14,14 +14,13 @@ CSSLint.addRule({
     //initialization
     init: function(parser, reporter){
         var rule = this,
-            count = 0,
             fontFaceRule = false,
             firstSrc     = true,
             ruleFailed    = false,
             line, col;
 
         // Mark the start of a @font-face declaration so we only test properties inside it
-        parser.addListener("startfontface", function(event){
+        parser.addListener("startfontface", function(){
             fontFaceRule = true;
         });
 
@@ -55,7 +54,7 @@ CSSLint.addRule({
         });
 
         // Back to normal rules that we don't need to test
-        parser.addListener("endfontface", function(event){
+        parser.addListener("endfontface", function(){
             fontFaceRule = false;
 
             if (ruleFailed) {
diff --git a/src/rules/compatible-vendor-prefixes.js b/src/rules/compatible-vendor-prefixes.js
@@ -107,7 +107,7 @@ CSSLint.addRule({
             inKeyFrame = event.prefix || true;
         });
 
-        parser.addListener("endkeyframes", function (event) {
+        parser.addListener("endkeyframes", function () {
             inKeyFrame = false;
         });
 
@@ -123,7 +123,7 @@ CSSLint.addRule({
             }
         });
 
-        parser.addListener("endrule", function (event) {
+        parser.addListener("endrule", function () {
             if (!properties.length) {
                 return;
             }
diff --git a/src/rules/duplicate-properties.js b/src/rules/duplicate-properties.js
@@ -17,7 +17,7 @@ CSSLint.addRule({
             properties,
             lastProperty;
 
-        function startRule(event){
+        function startRule(){
             properties = {};
         }
 
diff --git a/src/rules/fallback-colors.js b/src/rules/fallback-colors.js
@@ -27,7 +27,7 @@ CSSLint.addRule({
             },
             properties;
 
-        function startRule(event){
+        function startRule(){
             properties = {};
             lastProperty = null;
         }
diff --git a/src/rules/known-properties.js b/src/rules/known-properties.js
@@ -16,7 +16,6 @@ CSSLint.addRule({
         var rule = this;
 
         parser.addListener("property", function(event){
-            var name = event.property.text.toLowerCase();
 
             // the check is handled entirely by the parser-lib (https://github.com/nzakas/parser-lib)
             if (event.invalid) {
diff --git a/src/rules/outline-none.js b/src/rules/outline-none.js
@@ -31,7 +31,7 @@ CSSLint.addRule({
             }
         }
 
-        function endRule(event){
+        function endRule(){
             if (lastRule){
                 if (lastRule.outline){
                     if (lastRule.selectors.toString().toLowerCase().indexOf(":focus") == -1){
diff --git a/src/rules/rules-count.js b/src/rules/rules-count.js
@@ -12,8 +12,7 @@ CSSLint.addRule({
 
     //initialization
     init: function(parser, reporter){
-        var rule = this,
-            count = 0;
+        var count = 0;
 
         //count each rule
         parser.addListener("startrule", function(){
diff --git a/src/rules/shorthand.js b/src/rules/shorthand.js
@@ -41,7 +41,7 @@ CSSLint.addRule({
             }
         }
 
-        function startRule(event){
+        function startRule(){
             properties = {};
         }
 
@@ -71,8 +71,7 @@ CSSLint.addRule({
 
         //check for use of "font-size"
         parser.addListener("property", function(event){
-            var name = event.property.toString().toLowerCase(),
-                value = event.value.parts[0].value;
+            var name = event.property.toString().toLowerCase();
 
             if (propertiesToCheck[name]){
                 properties[name] = 1;
diff --git a/src/rules/text-indent.js b/src/rules/text-indent.js
@@ -18,13 +18,13 @@ CSSLint.addRule({
             direction;
 
 
-        function startRule(event){
+        function startRule(){
             textIndent = false;
             direction = "inherit";
         }
 
         //event handler for end of rules
-        function endRule(event){
+        function endRule(){
             if (textIndent && direction != "ltr"){
                 reporter.report("Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set direction for that item to ltr.", textIndent.line, textIndent.col, rule);
             }
diff --git a/src/rules/unique-headings.js b/src/rules/unique-headings.js
@@ -53,7 +53,7 @@ CSSLint.addRule({
             }
         });
 
-        parser.addListener("endstylesheet", function(event){
+        parser.addListener("endstylesheet", function(){
             var prop,
                 messages = [];
 
diff --git a/src/rules/universal-selector.js b/src/rules/universal-selector.js
@@ -18,8 +18,7 @@ CSSLint.addRule({
             var selectors = event.selectors,
                 selector,
                 part,
-                modifier,
-                i, j, k;
+                i;
 
             for (i=0; i < selectors.length; i++){
                 selector = selectors[i];
diff --git a/src/rules/unqualified-attributes.js b/src/rules/unqualified-attributes.js
@@ -20,7 +20,7 @@ CSSLint.addRule({
                 selector,
                 part,
                 modifier,
-                i, j, k;
+                i, k;
 
             for (i=0; i < selectors.length; i++){
                 selector = selectors[i];
diff --git a/src/rules/vendor-prefix.js b/src/rules/vendor-prefix.js
@@ -83,10 +83,10 @@ CSSLint.addRule({
         }
 
         //event handler for end of rules
-        function endRule(event){
+        function endRule(){
             var prop,
-                i, len,
-                standard,
+                i,
+                len,
                 needed,
                 actual,
                 needsStandard = [];

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ CSSLint.addFormatter({`
`44`	`44`	`return options.quiet ? "" : filename + ": Lint Free!";`
`45`	`45`	`}`
`46`	`46`
`47`		`- CSSLint.Util.forEach(messages, function(message, i) {`
	`47`	`+ CSSLint.Util.forEach(messages, function(message) {`
`48`	`48`	`if (message.rollup) {`
`49`	`49`	`output += filename + ": " + capitalize(message.type) + " - " + message.message + "\n";`
`50`	`50`	`} else {`