Skip to content

Commit a5631b0

Browse files
committed
Consider selectors containg #id or .class qualified (review tweaks)
1 parent 2ad0b73 commit a5631b0

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

tests/rules/unqualified-attributes.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@
1313
Assert.areEqual("Unqualified attribute selectors are known to be slow.", result.messages[0].message);
1414
},
1515

16-
"A selector that contains a class is considered qualified": function(){
17-
var result = CSSLint.verify("p [href].fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
18-
Assert.areEqual(0, result.messages.length);
19-
},
20-
21-
"A selector that contains an ID is considered qualified": function(){
22-
var result = CSSLint.verify("p [href]#fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
23-
Assert.areEqual(0, result.messages.length);
24-
},
25-
2616
"Using an unqualified attribute selector as the right-most part should result in a warning": function() {
2717
var result = CSSLint.verify("p div [type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
2818
Assert.areEqual(1, result.messages.length);
@@ -38,8 +28,17 @@
3828
"Using a qualified attribute selector should not result in a warning": function() {
3929
var result = CSSLint.verify("input[type=text] { font-size: 10px; } ", {"unqualified-attributes": 1 });
4030
Assert.areEqual(0, result.messages.length);
41-
}
31+
},
32+
33+
"Using an attribute selector qualified by a class should not result in a warning": function(){
34+
var result = CSSLint.verify(".fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
35+
Assert.areEqual(0, result.messages.length);
36+
},
4237

38+
"Using an attribute selector qualified by an ID should not result in a warning": function(){
39+
var result = CSSLint.verify("#fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
40+
Assert.areEqual(0, result.messages.length);
41+
}
4342

4443
}));
4544

0 commit comments

Comments
 (0)