Skip to content

Commit e4faab8

Browse files
committed
Minor fixes from code review by @jaredwy
- Typo 'were' -> 'where' - Add 'lint' alias for 'jshint' - Updated comments about suppressed JSHint warnings as they are Grunt recommendations, not JSHint default values.
1 parent 69376a2 commit e4faab8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Gruntfile.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -130,23 +130,20 @@ module.exports = function(grunt) {
130130
jshint: {
131131
options: {
132132
curly: true,
133-
//eqeqeq: true,
133+
//eqeqeq: true, TODO: Leaving off due to errors
134134
immed: true,
135135
latedef: true,
136136
newcap: true,
137137
noarg: true,
138138
sub: true,
139139
undef: true,
140-
//unused: true,
140+
//unused: true, TODO: Leaving off due to errors around unused instances of CSSLint
141141
boss: true,
142142
eqnull: true,
143143
// Copied from build.xml
144144
forin: true,
145145
noempty: true,
146146
rhino: false,
147-
// Temporary to suppress warnings that exist when using the latest JSHint
148-
eqeqeq: false,
149-
unused: false,
150147
globals: {
151148
jQuery: true
152149
}
@@ -203,6 +200,9 @@ module.exports = function(grunt) {
203200
// Default task.
204201
grunt.registerTask('default', ['test']);
205202

203+
//Alias for
204+
grunt.registerTask('lint', ['jshint']);
205+
206206
//Testing
207207
grunt.registerTask('test', ['clean:build', 'jshint', 'concat', 'yuitest']);
208208
grunt.registerTask('rhino', ['clean:build', 'jshint', 'concat', 'test_rhino']);
@@ -223,7 +223,7 @@ module.exports = function(grunt) {
223223
failures = [],
224224
stack = [];
225225

226-
//Eval each file so the tests are brought into this scope were CSSLint and YUITest are loaded already
226+
//Eval each file so the tests are brought into this scope where CSSLint and YUITest are loaded already
227227
files.forEach(function(filepath) {
228228
eval(grunt.file.read(filepath));
229229
});

0 commit comments

Comments
 (0)